Created attachment 232905 [details] v1 Moin moin desktop@ would like to ask for an exp-run to update devel/dbus to 1.14.0 . The patch is attached, and can also be found here: https://people.freebsd.org/~tcberner/patches/0001-devel-dbus-update-to-1.14.0.patch mfg Tobias
This looks fine
Committed. Thanks for the exp-run.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=692fe38479ebe04afe9bee34f68adfb52c1be91f commit 692fe38479ebe04afe9bee34f68adfb52c1be91f Author: Tobias C. Berner <tcberner@FreeBSD.org> AuthorDate: 2022-04-02 19:24:00 +0000 Commit: Tobias C. Berner <tcberner@FreeBSD.org> CommitDate: 2022-04-30 09:15:12 +0000 devel/dbus: update to 1.14.0 Changelog: https://dbus.freedesktop.org/doc/NEWS Exp-run by: antoine PR: 263014 devel/dbus/Makefile | 8 +++----- devel/dbus/distinfo | 6 +++--- .../files/patch-dbus_dbus-sysdeps-unix.c (gone) | 21 --------------------- devel/dbus/pkg-plist | 4 +++- 4 files changed, 9 insertions(+), 30 deletions(-)
I'm reopening this since the update was reverted and I think this is a good place tom gather information on how to fix it and reapply the update to the ports tree. As stated in the mailing lists, this update caused breakage for xfce desktop. I'm investigating the issue and I'll post findings here.
I have a first thing I noticed by comparing the build logs. Version 1.14 has a strange line at the end of its configure step, where it resumes what it configured, here is a diff (abridged) I created between the old and new version log: Building inotify support: no Building kqueue support: yes Building systemd support: no - Building X11 code: yes + Traditional activation: yes + Building X11 code: Building Doxygen docs: no + Building Qt help file: no Building Ducktype docs: no Building XML docs: yes Building launchd support: no As you can see, the new log misses the "yes" after "Building X11 code:". Could be just an output glitch but it could also be the very cause of the issue we are seeing.
I've marked this as "See also" on Bug 263696. As I entered URL instead of Bug ID (IIRC, entering Bug ID didn't work as intended before), the Bug ID is not shown there and head of summary is shown instead.
Created attachment 233629 [details] v2 I found out what is going on. Upstream configure script has a bug, if it is passed "--with-x" it defines with-x=yes, but then it only checks it for the auto value, and the yes case ends up being treated like the "no" case. This means the failure I was seeing were due to dbus being actually compiled with no X11 support. Upstream already patched this [1], so I'm attaching a patch that simply imports upstream patch directly in the configure script. Tested this patch with XFCE and now everything looks fine. [1] https://gitlab.freedesktop.org/dbus/dbus/-/commit/fdbb32bd1f3c972d3d5fd3998930749206a1095a
(In reply to Guido Falsi from comment #7) Thanks! The uploaded v2 patch fixed my issue on chenese/fcitx. Tested on src stable/13 git 963fdecd1a26676626a7067965a54ca7d5fa48fb, amd64.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ec8a7fefd2457e946e8ac75b8b5725557b646d80 commit ec8a7fefd2457e946e8ac75b8b5725557b646d80 Author: Tobias C. Berner <tcberner@FreeBSD.org> AuthorDate: 2022-05-03 07:21:38 +0000 Commit: Guido Falsi <madpilot@FreeBSD.org> CommitDate: 2022-05-03 07:28:16 +0000 devel/dbus: update to 1.14.0 - Update posrt again with patch imported from upstream to fix [1] configure script behavior when --with-x is passed on its command line PR: 263014 Obtained from: https://gitlab.freedesktop.org/dbus/dbus/-/commit/fdbb32bd1f3c972d3d5fd3998930749206a1095a [1] devel/dbus/Makefile | 7 +++---- devel/dbus/distinfo | 6 +++--- devel/dbus/files/patch-configure (new) | 11 +++++++++++ .../files/patch-dbus_dbus-sysdeps-unix.c (gone) | 21 --------------------- devel/dbus/pkg-plist | 4 +++- 5 files changed, 20 insertions(+), 29 deletions(-)
v2 patch committed. Thanks!
Now devel/dbus depends on itself if you enable INLINE_IMAGE option for www/w3m. make index error: make_index: Circular dependency loop found: dbus-1.14.0,1 depends upon itself. poudriere error: Error: Dependency loop detected: These packages depend on each other: gtk2-2.24.33 gobject-introspection-1.72.0,1 glib-2.70.4_5,2 dbus-1.14.0,1 xmlto-0.0.28 w3m-0.5.3.20220429
(In reply to Ting-Wei Lan from comment #11) Try getting back dependency from textproc/xmlto to textproc/minixmlto caused build failure on devel/dbus. So the solution would not be simple. Maybe, there would be 2 candidates. *Default textproc/xmlto to depend on www/lynx instead of www/w3m. *Separate www/w3m and www/w3m-img, including variants on japanese/. Change executable name of w3m-img to avoid conflict. Disallow installing inline image supported one as www/w3m, but www/w3m-img. Disallow -img version to be a dependency of anything. The first idea could cause changes of behaviour on xmlto, so, if I am the maintainer, I'd prefer second idea. If possible and upstream accepts, fixing dbus1.14 to be buildable with minixmlto is the best way, though, but it cannot be achieved by FreeBSD community alone.