Bug 263102 - [exp-run] Purging cdefs macros from FreeBSD
Summary: [exp-run] Purging cdefs macros from FreeBSD
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Baldwin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-06 20:49 UTC by John Baldwin
Modified: 2022-05-13 22:55 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Baldwin freebsd_committer freebsd_triage 2022-04-06 20:49:38 UTC
Please run an exp-run for with a world patched with https://github.com/freebsd/freebsd-src/compare/main...bsdjhb:cdefs_h.diff
Comment 1 Antoine Brodin freebsd_committer 2022-04-09 19:06:11 UTC
Exp-run looks fine
Comment 2 commit-hook freebsd_committer 2022-04-12 17:11:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=b8717a8709b297a7bdbcfae29e384cda9ce9c89a

commit b8717a8709b297a7bdbcfae29e384cda9ce9c89a
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:06:00 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-12 17:06:00 +0000

    Remove checks for __GNUCLIKE macros for varargs.

    All supported compilers (modern versions of GCC and clang) support
    these.

    PR:             263102 (exp-run)
    Reviewed by:    brooks, imp
    Differential Revision:  https://reviews.freebsd.org/D34800

 sys/sys/_stdarg.h | 2 --
 sys/sys/_types.h  | 7 +------
 2 files changed, 1 insertion(+), 8 deletions(-)
Comment 3 commit-hook freebsd_committer 2022-04-12 17:11:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=5ab33279ad2a5283fb11f8411b53093dfc1c41c6

commit 5ab33279ad2a5283fb11f8411b53093dfc1c41c6
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:05:50 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-12 17:05:50 +0000

    Remove checks for __GNUCLIKE___TYPEOF assuming it is always true.

    All supported compilers (modern versions of GCC and clang) support
    this.

    PR:             263102 (exp-run)
    Reviewed by:    brooks, imp, emaste
    Differential Revision:  https://reviews.freebsd.org/D34798

 sys/amd64/include/pcpu.h | 8 --------
 sys/i386/include/pcpu.h  | 8 --------
 2 files changed, 16 deletions(-)
Comment 4 commit-hook freebsd_committer 2022-04-12 17:11:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=87445068f96dffeb4e7f733eb155bb7caf47b5c2

commit 87445068f96dffeb4e7f733eb155bb7caf47b5c2
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:06:04 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-12 17:06:04 +0000

    Remove check for __CC_SUPPORTS___FUNC__.

    __func__ is part of C99.

    PR:             263102 (exp-run)
    Reviewed by:    brooks, imp, emaste
    Differential Revision:  https://reviews.freebsd.org/D34801

 sys/dev/ichsmb/ichsmb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer 2022-04-12 17:11:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=5f9c9ae2f22b509a61aaab99aa7bfe28f4dfb914

commit 5f9c9ae2f22b509a61aaab99aa7bfe28f4dfb914
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:06:13 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-12 17:06:13 +0000

    Remove checks for __CC_SUPPORTS_WARNING assuming it is always true.

    All supported compilers (modern versions of GCC and clang) support
    this.

    PR:             263102 (exp-run)
    Reviewed by:    brooks, imp
    Differential Revision:  https://reviews.freebsd.org/D34803

 sys/amd64/include/limits.h   | 4 ----
 sys/arm/include/limits.h     | 4 ----
 sys/i386/include/limits.h    | 4 ----
 sys/i386/include/speaker.h   | 4 ----
 sys/powerpc/include/limits.h | 4 ----
 sys/sys/syslimits.h          | 5 -----
 6 files changed, 25 deletions(-)
Comment 6 commit-hook freebsd_committer 2022-04-12 17:11:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=9f92ef766ae0c0349af41e592b3bd3b444af4f63

commit 9f92ef766ae0c0349af41e592b3bd3b444af4f63
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:05:55 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-12 17:05:55 +0000

    Remove checks for __GNUCLIKE___SECTION assuming it is always true.

    All supported compilers (modern versions of GCC and clang) support
    this.

    PR:             263102 (exp-run)
    Reviewed by:    brooks, imp, emaste
    Differential Revision:  https://reviews.freebsd.org/D34799

 sys/sys/linker_set.h | 4 ----
 1 file changed, 4 deletions(-)
Comment 7 commit-hook freebsd_committer 2022-04-12 17:11:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=3d6f4411e45f49dc0fef6d428615df5107ce2e5d

commit 3d6f4411e45f49dc0fef6d428615df5107ce2e5d
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:06:18 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-12 17:06:18 +0000

    Remove checks for <sys/cdefs.h> being included.

    These files no longer depend on the macros required when these checks
    were added.

    PR:             263102 (exp-run)
    Reviewed by:    brooks, imp, emaste
    Differential Revision:  https://reviews.freebsd.org/D34804

 sys/amd64/include/atomic.h   | 4 ----
 sys/amd64/include/cpufunc.h  | 4 ----
 sys/amd64/include/pcpu.h     | 4 ----
 sys/arm/include/armreg.h     | 4 ----
 sys/i386/include/atomic.h    | 4 ----
 sys/i386/include/cpufunc.h   | 4 ----
 sys/i386/include/pcpu.h      | 4 ----
 sys/powerpc/include/atomic.h | 4 ----
 sys/riscv/include/profile.h  | 4 ----
 sys/sys/linker_set.h         | 4 ----
 sys/x86/include/x86_ieeefp.h | 4 ----
 11 files changed, 44 deletions(-)
Comment 8 commit-hook freebsd_committer 2022-04-12 17:11:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=1c1bf5bd7c1e479a7889839b941f53e689aa2569

commit 1c1bf5bd7c1e479a7889839b941f53e689aa2569
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:05:39 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-12 17:05:39 +0000

    x86: Remove silly checks for <sys/cdefs.h>.

    These headers #include <sys/cdefs.h> right after checking if it has
    already been #included.  The nested #include already existed when the
    check for _SYS_CDEFS_H_ was added, so the check shouldn't have been
    added in the first place.

    PR:             263102 (exp-run)
    Reported by:    brooks
    Reviewed by:    brooks, imp, emaste
    Differential Revision:  https://reviews.freebsd.org/D34796

 sys/amd64/include/in_cksum.h | 4 ----
 sys/i386/include/in_cksum.h  | 4 ----
 2 files changed, 8 deletions(-)
Comment 9 commit-hook freebsd_committer 2022-04-12 17:11:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=17554af4e8531f443fce1a58ab6d4b45d82af5f2

commit 17554af4e8531f443fce1a58ab6d4b45d82af5f2
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:05:34 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-12 17:05:34 +0000

    ce,cp: Remove pointless checks for <sys/cdefs.h>

    Both of these headers check for _SYS_CDEFS_H_ after including
    <sys/param.h> which itself includes <sys/cdefs.h>.

    PR:             263102 (exp-run)
    Reviewed by:    brooks, imp, emaste
    Differential Revision:  https://reviews.freebsd.org/D34795

 sys/dev/ce/machdep.h | 4 ----
 sys/dev/cp/machdep.h | 4 ----
 2 files changed, 8 deletions(-)
Comment 10 commit-hook freebsd_committer 2022-04-12 17:11:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=56f5947a7102554729e0400f08b0f4d50a2d0827

commit 56f5947a7102554729e0400f08b0f4d50a2d0827
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:05:45 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-12 17:05:45 +0000

    Remove checks for __GNUCLIKE_ASM assuming it is always true.

    All supported compilers (modern versions of GCC and clang) support
    this.

    Many places didn't have an #else so would just silently do the wrong
    thing.  Ancient versions of icc (the original motivation for this) are
    no longer a compiler FreeBSD supports.

    PR:             263102 (exp-run)
    Reviewed by:    brooks, imp
    Differential Revision:  https://reviews.freebsd.org/D34797

 lib/msun/src/math_private.h      |   6 +-
 sys/amd64/amd64/fpu.c            |  22 -----
 sys/amd64/include/atomic.h       |  43 ---------
 sys/amd64/include/cpufunc.h      |   6 +-
 sys/amd64/include/ieeefp.h       |  10 +-
 sys/amd64/include/pcpu.h         |   6 +-
 sys/amd64/include/profile.h      |   6 --
 sys/arm64/include/profile.h      |   4 -
 sys/crypto/via/padlock_cipher.c  |   2 -
 sys/crypto/via/padlock_hash.c    |   4 -
 sys/dev/random/nehemiah.c        |   2 -
 sys/dev/sound/pcm/feeder_rate.c  |   2 +-
 sys/i386/i386/in_cksum_machdep.c | 192 ---------------------------------------
 sys/i386/i386/npx.c              |  21 -----
 sys/i386/include/atomic.h        |  47 ----------
 sys/i386/include/cpufunc.h       |   6 +-
 sys/i386/include/ieeefp.h        |   4 -
 sys/i386/include/in_cksum.h      |   9 --
 sys/i386/include/pcpu.h          |   6 +-
 sys/i386/include/profile.h       |   6 --
 sys/x86/include/bus.h            |  42 ---------
 sys/x86/include/x86_ieeefp.h     |   4 -
 sys/x86/x86/identcpu.c           |   4 -
 23 files changed, 19 insertions(+), 435 deletions(-)
Comment 11 commit-hook freebsd_committer 2022-04-12 17:11:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=f08613087a9756886a1f219b67b0e79a1efd5e8c

commit f08613087a9756886a1f219b67b0e79a1efd5e8c
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:06:09 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-04-12 17:06:09 +0000

    Remove checks for __CC_SUPPORTS__INLINE assuming it is always true.

    All supported compilers (modern versions of GCC and clang) support
    this.

    PR:             263102 (exp-run)
    Reviewed by:    imp
    Differential Revision:  https://reviews.freebsd.org/D34802

 sys/amd64/include/cpufunc.h | 69 ------------------------------------------
 sys/dev/ce/machdep.h        |  6 +---
 sys/dev/cp/machdep.h        |  6 +---
 sys/i386/include/cpufunc.h  | 74 ---------------------------------------------
 4 files changed, 2 insertions(+), 153 deletions(-)
Comment 12 commit-hook freebsd_committer 2022-05-13 22:55:30 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=2cb2e6691fae68fa081bad5624e54b345002b0fa

commit 2cb2e6691fae68fa081bad5624e54b345002b0fa
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:05:34 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-05-13 20:11:30 +0000

    ce,cp: Remove pointless checks for <sys/cdefs.h>

    Both of these headers check for _SYS_CDEFS_H_ after including
    <sys/param.h> which itself includes <sys/cdefs.h>.

    PR:             263102 (exp-run)
    Reviewed by:    brooks, imp, emaste
    Differential Revision:  https://reviews.freebsd.org/D34795

    (cherry picked from commit 17554af4e8531f443fce1a58ab6d4b45d82af5f2)

 sys/dev/ce/machdep.h | 4 ----
 sys/dev/cp/machdep.h | 4 ----
 2 files changed, 8 deletions(-)
Comment 13 commit-hook freebsd_committer 2022-05-13 22:55:30 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=848513a77f2723ddf32510de0f1a212fb9d211d6

commit 848513a77f2723ddf32510de0f1a212fb9d211d6
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-04-12 17:05:39 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-05-13 20:12:26 +0000

    x86: Remove silly checks for <sys/cdefs.h>.

    These headers #include <sys/cdefs.h> right after checking if it has
    already been #included.  The nested #include already existed when the
    check for _SYS_CDEFS_H_ was added, so the check shouldn't have been
    added in the first place.

    PR:             263102 (exp-run)
    Reported by:    brooks
    Reviewed by:    brooks, imp, emaste
    Differential Revision:  https://reviews.freebsd.org/D34796

    (cherry picked from commit 1c1bf5bd7c1e479a7889839b941f53e689aa2569)

 sys/amd64/include/in_cksum.h | 4 ----
 sys/i386/include/in_cksum.h  | 4 ----
 2 files changed, 8 deletions(-)