Created attachment 233144 [details] Bump django dependency to 3.2 Add a patch to incorporate an upstream pull-request www/py-django-tagging to address bug #261313 (Django 2.2 deprecation) and set dependency to Django 3.2 Poudriere: OK
Hi Kevin, thank you for the patch, it builds fine. There's one problem at the moment: Because www/py-django-tagging is required by www/py-graphite-web, which isn't compatible with Django 3.2, we cannot yet switch over to Django 3.2. Otherwise www/py-graphite-web would break during installation due conflicting dependencies (= Django 2.2 vs. Django 3.2). I set www/py-graphite-web to expire in ports 94d5b74e399 with an expiration date of 2022-06-30 like all other ports that have no support for newer versions of Django. There are two options how to proceed: a) Commit the upstream pull-request, bump the PORTREVISION and switch over to Django 3.2 once www/py-graphite-web gets updated or removed. b) Wait until www/py-graphite-web gets updated or removed and then commit your attached patch. Which of the two options would you prefer? If you have another idea I'm all ears for it.
Aah, I didn't think of that did I? Option (a) does give a slightly better lead time for migrations to Django 3.2 so is preferable, however, given the extra steps involved in that approach I have no issues with option (b) if you'd prefer. I think it's a fairly small difference in real-world terms so I'm happy to defer judgement to yourself as the person having to do the remaining work.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=80b4f695a700f521a0c0415009a1536cd5987123 commit 80b4f695a700f521a0c0415009a1536cd5987123 Author: Kevin Golding <ports@caomhin.org> AuthorDate: 2022-06-30 07:04:53 +0000 Commit: Kai Knoblich <kai@FreeBSD.org> CommitDate: 2022-06-30 07:19:28 +0000 www/py-django-tagging: Add Django 3.2 compatibility * Add a patch to incorporate an upstream pull-request [1] to address the Django 2.2 deprecation [2] and set dependency to Django 3.2. PR: 263216, 261313 [2] Obtained from: [1] https://github.com/Fantomas42/django-tagging/pull/23/ www/py-django-tagging/Makefile | 3 ++- .../files/patch-tagging_models.py (new) | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-)
(In reply to Kevin Golding from comment #2) Committed, thanks a lot for your patch!