Created attachment 233183 [details] patch Updates the grafana8 to 8.4.5. Main thing to do that is that with GO 1.18 new alerts will break grafana and this should be fixed here see https://github.com/grafana/grafana/issues/47093 Since i have no idea how Go or the FreeBSD Go packaging works please review. Attached testport result and the port runs with my config (which does not need the new alerts) Thanks https://twitter.com/jan666 for doing most of the work on this patch.
Created attachment 233184 [details] testport output
Hi Sir l33tname, I'm waiting fix for https://github.com/grafana/grafana/issues/45752. I'll try to build grafana 8.3.6 with Go 1.17 and return back.
Created attachment 233186 [details] grafana8.diff Sir l33tnam, try the attached patch (build with Go 1.17).
Created attachment 233200 [details] patch upgrade to 8.4.6
Created attachment 233201 [details] testport output
Boris Korzun I mean we can run this port with go1.17 if the latest release does not work with go1.18 but for me it works now but i dont use the new alerts
Comment on attachment 233200 [details] patch upgrade to 8.4.6 The patch doesn't fix: - https://github.com/grafana/grafana/issues/45752 - https://github.com/grafana/grafana/issues/47093
Created attachment 233209 [details] patch upgrade to 8.4.6 using go117 I combined both patches (had to make makesum to update distinfo). So now it's 8.4.6 using go117. works perfect for me (no crashes like when building with go118)
Created attachment 233211 [details] grafana8.diff Approved update to 8.3.6_2 (with go117).
Created attachment 233225 [details] tesport output - patch upgrade to 8.4.6 using go117 I tested the patch from Jan looks good to me lets go with this patch and remove the go117 with the next version if grafana works with go118
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=84e9e60267fa5b19ab022b8c8b750513b678a84d commit 84e9e60267fa5b19ab022b8c8b750513b678a84d Author: Boris Korzun <drtr0jan@yandex.ru> AuthorDate: 2022-04-20 15:15:24 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2022-04-20 15:17:47 +0000 www/grafana8: Fix runtime issue. grafana8 8.3.6 doesn't work with go 1.18. Switch to go 1.17 PR: 263251 www/grafana8/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks! Please open a new pr if you want to update the port to 8.4.6
sure but why didn't you pick my patch? This was my issue which was cooped by Boris im super confused what is happening here tbh - anyway please have a look at #263438 and let me know if anything is missing to be commited
(In reply to Sir l33tname from comment #13) The maintainer has approved the patch at comment 9 not the upgrade to 8.4
(In reply to Sir l33tname from comment #13) Your patch has been affected by regression from https://github.com/grafana/grafana/issues/45752 I'm preparing update to 8.4.7. It will be approved after testing.
(In reply to Mikael Urankar from comment #12) I think, commit should be merged to quarterly as lang/go has been upgraded to 1.18 in quarterly too.
(In reply to Boris Korzun from comment #16) lang/go117 is not merged in 2022Q2
A commit in branch 2022Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8691a46b4456391c3df6566f8ecd1208201f5e8f commit 8691a46b4456391c3df6566f8ecd1208201f5e8f Author: Boris Korzun <drtr0jan@yandex.ru> AuthorDate: 2022-04-20 15:15:24 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2022-04-22 11:47:20 +0000 www/grafana8: Fix runtime issue. grafana8 8.3.6 doesn't work with go 1.18. Switch to go 1.17 PR: 263251 (cherry picked from commit 84e9e60267fa5b19ab022b8c8b750513b678a84d) www/grafana8/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)