Bug 263502 - audio/lmms fails to build with error unknown type name 'CARLA_EXPORT' using poudriere on amd64 13-Stable
Summary: audio/lmms fails to build with error unknown type name 'CARLA_EXPORT' using p...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-24 00:14 UTC by Robert Cina
Modified: 2022-04-24 19:56 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rodrigo)

Attachments
lmms patch (993 bytes, patch)
2022-04-24 10:35 UTC, Rodrigo Osorio 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Cina 2022-04-24 00:14:32 UTC 
The port audio/lmms fails to build for me using poudriere on Stable-13 amd64.

The error displayed is unknown type name 'CARLA_EXPORT'.

The build log showing the error follows;

In file included from /wrkdirs/usr/ports/audio/lmms/work/.build/plugins/carlabase/moc_carla.cpp:10:
/wrkdirs/usr/ports/audio/lmms/work/.build/plugins/carlabase/../../../lmms-1.2.2/plugins/carlabase/carla.h:37:5: error: unknown type name 'CARLA_EXPORT'
    CARLA_EXPORT
    ^
/wrkdirs/usr/ports/audio/lmms/work/.build/plugins/carlabase/../../../lmms-1.2.2/plugins/carlabase/carla.h:38:33: error: expected ';' after top level declarator
    const NativePluginDescriptor* carla_get_native_patchbay_plugin();
                                ^
                                ;
/wrkdirs/usr/ports/audio/lmms/work/.build/plugins/carlabase/../../../lmms-1.2.2/plugins/carlabase/carla.h:40:5: error: unknown type name 'CARLA_EXPORT'
    CARLA_EXPORT
    ^
/wrkdirs/usr/ports/audio/lmms/work/.build/plugins/carlabase/../../../lmms-1.2.2/plugins/carlabase/carla.h:41:33: error: expected ';' after top level declarator
    const NativePluginDescriptor* carla_get_native_rack_plugin();
                                ^
Comment 1 Rodrigo Osorio freebsd_committer freebsd_triage 2022-04-24 08:51:52 UTC 
Issue reproduced in my poudriere environment
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2022-04-24 10:35:04 UTC 
Created attachment 233431 [details]
lmms patch

@robert: This patch fixes the build issue, can you test it and see if lmms works as expected ?
Comment 3 Robert Cina 2022-04-24 16:18:12 UTC 
Yes I can confirm that the patch you provided builds the port successfully now.

Thanks for the patch.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-04-24 19:55:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=61d2a0a94c75e53c5e30141dce3a46d148df9ba4

commit 61d2a0a94c75e53c5e30141dce3a46d148df9ba4
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2022-04-24 10:09:04 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2022-04-24 19:45:44 +0000

    audio/lmms: patch lmms after libcarla upgrade

    LibCarla 2.4.3 replace CARLA_EXPORT macro with
    separate API / PLUGIN export options. This breaks
    lmms build.
    Add a patch to lmms carla plugin to fix the build.

    PR:                             263502
    Reported by:    Robert Cina <transitive@gmail.com>

 audio/lmms/Makefile                                    |  2 +-
 audio/lmms/files/patch-plugins_carlabase_carla.h (new) | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2022-04-24 19:56:07 UTC 
Patch committed, thanks