Bug 263826 - security/xmlsec1: Fails to build with libressl: app.c:440:57: error: cast to 'void *' from smaller integer type 'int' [-Werror,-Wint-to-void-pointer-cast]
Summary: security/xmlsec1: Fails to build with libressl: app.c:440:57: error: cast to ...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Hiroki Sato
URL:
Keywords: needs-patch, needs-qa
: 263827 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-05-06 19:27 UTC by Ivan Rozhuk
Modified: 2024-02-08 03:54 UTC (History)
6 users (show)

See Also:
bugzilla: maintainer-feedback? (hrs)
koobs: merge-quarterly?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2022-05-06 19:27:28 UTC
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../.. -DPACKAGE=\"xmlsec1\" -I../../include -I../../include -D__XMLSEC_FUNCTION__=__func__ -DXMLSEC_NO_SIZE_T -DXMLSEC_NO_GOST=1 -DXMLSEC_NO_GOST2012=1 -DXMLSEC_DL_LIBLTDL=1 -I/usr/local/include -I/usr/local/include/openssl -DXMLSEC_CRYPTO_OPENSSL=1 -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include/libxml2 -isystem /usr/local/include -O2 -pipe -O3 -pipe -funroll-loops -mretpoline -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -fdebug-prefix-map=/tmp/ports/usr/ports/security/xmlsec1/work/xmlsec1-1.2.34=. -Werror -fno-builtin-memset -MT libxmlsec1_openssl_la-bn.lo -MD -MP -MF .deps/libxmlsec1_openssl_la-bn.Tpo -c bn.c -o libxmlsec1_openssl_la-bn.o >/dev/null 2>&1
app.c:440:65: error: implicit declaration of function 'UI_null' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    if(ENGINE_ctrl_cmd(engine, "SET_USER_INTERFACE", 0, (void *)UI_null(), 0, 1) < 0) {
                                                                ^
app.c:440:57: error: cast to 'void *' from smaller integer type 'int' [-Werror,-Wint-to-void-pointer-cast]
    if(ENGINE_ctrl_cmd(engine, "SET_USER_INTERFACE", 0, (void *)UI_null(), 0, 1) < 0) {
                                                        ^~~~~~~~~~~~~~~~~
app.c:456:36: error: cast to 'UI_METHOD *' (aka 'struct ui_method_st *') from smaller integer type 'int' [-Werror,-Wint-to-pointer-cast]
                                   (UI_METHOD *)UI_null(),
                                   ^~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
gmake[5]: *** [Makefile:625: libxmlsec1_openssl_la-app.lo] Error 1
gmake[5]: *** Waiting for unfinished jobs....
Comment 1 Ivan Rozhuk 2022-05-06 19:27:57 UTC
With libressl from ports.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-05-06 20:25:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=29c7d4a9f83548fee47722fcc60ad33bbdfa9f87

commit 29c7d4a9f83548fee47722fcc60ad33bbdfa9f87
Author:     Hiroki Sato <hrs@FreeBSD.org>
AuthorDate: 2022-05-06 20:23:19 +0000
Commit:     Hiroki Sato <hrs@FreeBSD.org>
CommitDate: 2022-05-06 20:24:48 +0000

    security/xmlsec1: fix build when using libressl

    PR:     263826

 .../xmlsec1/files/patch-src-openssl-app.c (new)    | 70 ++++++++++++++++++++++
 1 file changed, 70 insertions(+)
Comment 3 Hiroki Sato freebsd_committer freebsd_triage 2022-05-06 20:27:18 UTC
(In reply to Ivan Rozhuk from comment #1)

Thanks for the report.  It should be fixed in 29c7d4a9f83548fee47722fcc60ad33bbdfa9f87.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2022-05-06 22:43:46 UTC
*** Bug 263827 has been marked as a duplicate of this bug. ***
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2022-05-06 22:46:02 UTC
@Hiroki Can we disable/override -Werror in the default port build? Fixing warnings is great (and should be fixed upstream). Also, is quarterly also affected?
Comment 6 Graham Perrin freebsd_committer freebsd_triage 2022-10-18 18:31:42 UTC
Please

Are today's bug 266262 comment 22 and bug 266920 comment 12 indicative of a need to bump the PORTREVISION here?
Comment 7 Ivan Rozhuk 2023-03-19 11:03:20 UTC
With libressl 3.6.2 - build ok.