Bug 263895 - dns/knot3: upgrade to 3.1.8
Summary: dns/knot3: upgrade to 3.1.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://www.knot-dns.cz/2022-04-28-ve...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-10 12:22 UTC by Leo Vandewoestijne
Modified: 2022-05-16 11:56 UTC (History)
1 user (show)

See Also:


Attachments
knot 3.1.8 (883 bytes, patch)
2022-05-10 12:22 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details | Diff
same file, unaltered (883 bytes, patch)
2022-05-11 16:36 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details | Diff
same file, unaltered, new extention (883 bytes, patch)
2022-05-16 08:26 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Vandewoestijne 2022-05-10 12:22:22 UTC
Created attachment 233836 [details]
knot 3.1.8

Simple patch to upgrade Knot3 to 3.1.8

Tested successful in poudriere.
Comment 1 Nuno Teixeira freebsd_committer 2022-05-11 09:55:46 UTC
Could you please provide a git diff?
Comment 2 Leo Vandewoestijne 2022-05-11 16:36:06 UTC
Created attachment 233860 [details]
same file, unaltered
Comment 3 Leo Vandewoestijne 2022-05-11 16:37:42 UTC
(In reply to Nuno Teixeira from comment #1)

> Could you please provide a git diff?
>
If I would be able to upload it.
Why do the first lines get truncated?
Comment 4 Leo Vandewoestijne 2022-05-11 16:40:35 UTC
The missing first two lines are:

diff --git a/dns/knot3/Makefile b/dns/knot3/Makefile
index 783407ba3272..7351d1972574 100644
Comment 5 Nuno Teixeira freebsd_committer 2022-05-12 07:31:31 UTC
just do 'git diff . > /tmp/port.diff' inside your port.
Comment 6 Nuno Teixeira freebsd_committer 2022-05-13 16:30:00 UTC
Are you using git to fetch ports tree?
Comment 7 Leo Vandewoestijne 2022-05-16 08:24:28 UTC
Yes, I know how to use git. It's not the problem.
The patch is being truncated during upload.
Comment 8 Leo Vandewoestijne 2022-05-16 08:26:42 UTC
Created attachment 233954 [details]
same file, unaltered, new extention

Unaltered file, new extention.
Comment 9 Leo Vandewoestijne 2022-05-16 08:28:30 UTC
OK:
Fails when using .patch
Succeeded with .diff
Comment 10 commit-hook freebsd_committer 2022-05-16 11:55:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=71d793f9056bb3cccc524858eec43d2454f692b6

commit 71d793f9056bb3cccc524858eec43d2454f692b6
Author:     Leo Vandewoestijne <freebsd@dns.company>
AuthorDate: 2022-05-16 11:53:06 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-05-16 11:53:06 +0000

    dns/knot3: Upgrade to 3.1.8

    ChangeLog: https://www.knot-dns.cz/2022-04-28-version-318.html

    PR:             263895

 dns/knot3/Makefile | 2 +-
 dns/knot3/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 11 Nuno Teixeira freebsd_committer 2022-05-16 11:56:20 UTC
Commited, thanks!