Bug 263949 - multimedia/gstreamer1-plugins-all fix, to regain a list of all plug-ins; and update package description
Summary: multimedia/gstreamer1-plugins-all fix, to regain a list of all plug-ins; and ...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL: https://github.com/freebsd/freebsd-po...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-13 05:08 UTC by Graham Perrin
Modified: 2022-05-14 17:49 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin 2022-05-13 05:08:33 UTC
<https://old.reddit.com/r/freebsd/comments/unvueb/-/>

From chat in IRC: 

> … (it was sourcing bsd.gstreamer.mk previously to get the list of 
> all plugins, which it no longer does, so it needs to be converted 
> to use _GST_PLUGINS_VER from gstreamer.mk)
Comment 1 Graham Perrin 2022-05-13 05:10:47 UTC
<https://www.freshports.org/multimedia/gstreamer1-plugins-all/#description>

Whilst here :-) maybe change the description, from: 

> Meta-port of all gstreamer-plugins with options.

– to: 

> Meta port of all GStreamer plug-ins.

(if it's truly all). 


Also, add WWW: 

https://gstreamer.freedesktop.org/


Options
=======

<https://www.freshports.org/multimedia/gstreamer1-plugins-all/#config>: 

> No options to configure
Comment 2 commit-hook freebsd_committer 2022-05-14 10:30:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8023c8e529f7d02fe723c98e745fb0317814d277

commit 8023c8e529f7d02fe723c98e745fb0317814d277
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-05-14 09:19:24 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-05-14 10:28:03 +0000

    multimedia/gstreamer1-plugins-all: fix metaport

    - remove option handling: an -all port that lets one disable parts does
      not make much sense.
      If only certain components are needed, they can be installed directly,
      without extra steps of configuring options.

    PR:             263949

 multimedia/gstreamer1-plugins-all/Makefile  | 26 +++++---------------------
 multimedia/gstreamer1-plugins-all/pkg-descr |  4 +++-
 2 files changed, 8 insertions(+), 22 deletions(-)
Comment 3 VVD 2022-05-14 12:53:39 UTC
This commit force install pulse, sndio and jack.
With pulse installed my sound is broken.

> If only certain components are needed, they can be installed directly, without extra steps of configuring options.
I can't - phonon-gstreamer-qt5-4.10.0_3 depends on plugins-all, but not on every "certain components".
# pkg info -r gstreamer1-plugins-all
gstreamer1-plugins-all-1.16_1:
         phonon-gstreamer-qt5-4.10.0_3
# pkg info -r phonon-gstreamer-qt5-4.10.0_3
phonon-gstreamer-qt5-4.10.0_3:
         plasma5-plasma-5.24.5

Please, revert back.
Comment 4 Graham Perrin 2022-05-14 13:17:10 UTC
(In reply to VVD from comment #3)

> … pulse, sndio and jack …

Respectively: 

<https://www.freshports.org/audio/gstreamer1-plugins-pulse/#requiredlib>
<https://www.freshports.org/audio/gstreamer1-plugins-sndio/#requiredlib>
<https://www.freshports.org/audio/gstreamer1-plugins-jack/#requiredlib>

As far as I can tell, these dependencies are not new; they're proper for

    multimedia/gstreamer1-plugins-all

– for all.
Comment 5 VVD 2022-05-14 15:32:32 UTC
(In reply to Graham Perrin from comment #4)
They was optional before this commit.
Comment 6 Tobias C. Berner freebsd_committer 2022-05-14 17:39:37 UTC
(In reply to VVD from comment #5)
Moin moin 

As mentioned in the commit message -- I do not quite see the point of options in an "-all" port (it's not called a '-some' port after all).

If you are choosing what to install via options, why not simply install the chosen packages directly.


mfg Tobias
Comment 7 Graham Perrin 2022-05-14 17:43:41 UTC
(In reply to Graham Perrin from comment #1)

> <https://www.freshports.org/multimedia/gstreamer1-plugins-all/#config>: 
> 
>> No options to configure

Ah, now I see (in the Wayback Machine): 

>> ===> The following configuration options are available …

<https://web.archive.org/web/20180216154606/https://www.freshports.org/multimedia/gstreamer1-plugins-all>
Comment 8 Graham Perrin 2022-05-14 17:49:00 UTC
(In reply to Tobias C. Berner from comment #6)

I tend to agree, however (comment 3) "phonon-gstreamer-qt5-4.10.0_3 depends on plugins-all" is eye-catching (and I can't test at the moment, sorry).