Bug 263953 - multimedia/nymphcast: fix build on armv7
Summary: multimedia/nymphcast: fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Adriaan de Groot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-13 14:46 UTC by Robert Clausecker
Modified: 2022-05-16 21:42 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (adridg)
fuz: merge-quarterly?


Attachments
multimedia/nymphcast: fix build on armv7 (2.65 KB, patch)
2022-05-13 14:46 UTC, Robert Clausecker
fuz: maintainer-approval? (adridg)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker 2022-05-13 14:46:48 UTC
Created attachment 233893 [details]
multimedia/nymphcast: fix build on armv7

The build failed due to an unsupported compiler option
-Wa,-mimplicit-it=thumb.  This option is not needed when
building with clang, doubly so when building in ARM mode,
which we do.

Please also consider changing the Makefile such that CC and CXX are respected.
This can be done e.g. by

    MAKE_ARGS= GCC=${CC} GPP=${CXX}

in the port Makefile.

Tested with Poudriere on armv7 FreeBSD 13.
Comment 1 Adriaan de Groot freebsd_committer 2022-05-13 18:38:42 UTC
Looks good to me, but .. wouldn't it *overall* be better to use `lang/angelscript` rather than a bundled copy? Is that something you would like to chase in NymphCast? (If not and you just want stuff to build on ARM, that's fine too and I'll land this instead)
Comment 2 Robert Clausecker 2022-05-13 19:04:31 UTC
(In reply to Adriaan de Groot from comment #1)

Hi, my mission is to make more ports build on armv7.  I don't care about this port specifically, it just looked like an issue that is easy to fix.

I agree that unbundling the dependency would be in general a better solution.  Feel free to do that instead of committing my patch.  If you post it here, I can check if it makes the build work on armv7.
Comment 3 commit-hook freebsd_committer 2022-05-16 19:00:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=78989b4e694c2a8264975fb6d64e3bf1c13762c2

commit 78989b4e694c2a8264975fb6d64e3bf1c13762c2
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-05-16 15:00:32 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2022-05-16 18:57:54 +0000

    multimedia/nymphcast: fix build on ARMv7

    nymphcast has a bundled copy of angelscript (TODO: use the
    one from ports instead) that doesn't build nicely on ARM
    because it passes in invalid compiler flags.

    PR:             263953
    Reported by:    Robert Clausecker

 multimedia/nymphcast/Makefile                |  1 +
 multimedia/nymphcast/files/patch-armv7 (new) | 58 ++++++++++++++++++++++++++++
 2 files changed, 59 insertions(+)
Comment 4 Robert Clausecker 2022-05-16 21:42:51 UTC
Thanks!  Please don't forget to MFH.