Bug 263989 - www/lua-resty-core: Update to 0.1.23
Summary: www/lua-resty-core: Update to 0.1.23
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Neel Chauhan
URL: https://github.com/openresty/lua-rest...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-15 12:13 UTC by Dmitry Wagin
Modified: 2022-05-22 10:27 UTC (History)
3 users (show)

See Also:


Attachments
lua-resty-core.diff (903 bytes, patch)
2022-05-15 12:13 UTC, Dmitry Wagin
dmitry.wagin: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Wagin 2022-05-15 12:13:53 UTC
Created attachment 233926 [details]
lua-resty-core.diff

Update to 0.1.23

https://github.com/openresty/lua-resty-core/releases/tag/v0.1.23
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-05-15 15:20:29 UTC
Hi,

1.
---
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/lua/5.1/ngx/ssl/clienthello.lua
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
---

2. Use DISTVERSION instead of PORTVERSION
https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-naming

3. Use portlint, portclippy and portfmt to a better Makefile format

Thanks,

Nuno Teixeira
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-05-17 04:51:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=31b425912357a97e6c54f2531cc84b1f394a2e90

commit 31b425912357a97e6c54f2531cc84b1f394a2e90
Author:     Dmitry Wagin <dmitry.wagin@ya.ru>
AuthorDate: 2022-05-17 04:50:26 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-05-17 04:50:26 +0000

    www/lua-resty-core: Update to 0.1.23

    Changes: https://github.com/openresty/lua-resty-core/releases/tag/v0.1.23

    PR:     263989

 www/lua-resty-core/Makefile | 2 +-
 www/lua-resty-core/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 3 Neel Chauhan freebsd_committer freebsd_triage 2022-05-17 04:53:13 UTC
Committed with corrections
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-05-17 04:53:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=72eb8ee73f3518581776bef8c1bbdc0aa7663f9f

commit 72eb8ee73f3518581776bef8c1bbdc0aa7663f9f
Author:     Dmitry Wagin <dmitry.wagin@ya.ru>
AuthorDate: 2022-05-17 04:52:32 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-05-17 04:52:32 +0000

    www/lua-resty-core: Makefile and pkg-plist corrections

    PR:     263989

 www/lua-resty-core/Makefile  | 8 ++++----
 www/lua-resty-core/pkg-plist | 1 +
 2 files changed, 5 insertions(+), 4 deletions(-)
Comment 5 Johan Ström 2022-05-22 07:59:27 UTC
After updating this package I can no longer start nginx:

nginx: [alert] failed to load the 'resty.core' module (https://github.com/openresty/lua-resty-core); ensure you are using an OpenResty release from https://openresty.org/en/download.html (reason: /usr/local/share/lua/5.1/resty/core/base.lua:24: ngx_http_lua_module 0.10.21 required) in /usr/local/etc/nginx/nginx.conf:539


lua-resty-core-0.1.23
nginx-1.20.2_9,2