Created attachment 233934 [details] git diff for archivers/libzip ``` archivers/libzip: Update to 1.8.0 * fixes LibreSSL 3.5 compatibility PR: ? ```
Thanks, the patch does look reasonable. Could you also include which releases you tested it with? Did zstd and lzma detection work in the configuration phase?
Created attachment 233958 [details] git diff for archivers/libzip (In reply to Raphael Kubo da Costa from comment #1) Wow, that was spectacularly bad! Don't know how that built on my system. Fixed this, and built it in vanilla currently supported versions https://brnrd.eu/poudriere/data/130amd64-git/2022-05-16_10h20m32s/logs/libzip-1.8.0.log https://brnrd.eu/poudriere/data/123i386-git/2022-05-16_10h20m48s/logs/libzip-1.8.0.log https://brnrd.eu/poudriere/data/123amd64-git/2022-05-16_10h39m01s/logs/libzip-1.8.0.log
`make stage-qa` in your logs indicates the following: Error: /usr/local/lib/libzip.so.5.4 is linked to /usr/local/lib/libzstd.so.1 from archivers/zstd but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libzstd.so:archivers/zstd Can you add the missing dependency?
Created attachment 235165 [details] git diff for archivers/libzip Added libzstd dependency
Comment on attachment 235165 [details] git diff for archivers/libzip lgtm, thank you!
Upstream is at 1.9.2 PORTVERSION --> DISTVERSION LIB_DEPENDS+= --> LIB_DEPENDS= Add GitHub as primary MASTER_SITE and libzip.org as fallback to offload upstream Reference: https://github.com/nih-at/libzip/releases/tag/v1.9.2
...also, please run make test to catch bugs =)
Created attachment 235253 [details] git diff for archivers/libzip archivers/libzip: Update to 1.9.2 * Use GitHub download (diizzy) * Prefer DISTVERSION (diizzy) * Adds zstd and lzma capability (diizzy) PR: 263996
Created attachment 235254 [details] make test output `make test` output and buildlogs https://brnrd.eu/poudriere/data/130amd64-git/2022-07-14_11h46m29s/logs/libzip-1.9.2.log https://brnrd.eu/poudriere/data/123amd64-git/2022-07-14_11h47m05s/logs/libzip-1.9.2.log https://brnrd.eu/poudriere/data/123i386-git/2022-07-14_11h46m47s/logs/libzip-1.9.2.log
Created attachment 235255 [details] Patch for libzip Incorporate changes by brnrd Switch back to MASTER_SITES (Porters Handbook USE_GITHUB) Remove unnecessary patch Do some minor adjustments to Makefile to follow Porters Handbook more closely
Comment on attachment 235255 [details] Patch for libzip lgtm, thank you
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7df84dbe4a304066c1ceda871429832b629620a1 commit 7df84dbe4a304066c1ceda871429832b629620a1 Author: Bernard Spil <brnrd@FreeBSD.org> AuthorDate: 2022-08-05 17:55:41 +0000 Commit: Bernard Spil <brnrd@FreeBSD.org> CommitDate: 2022-08-05 17:55:41 +0000 archivers/libzip: Update to 1.9.2 PR: 263996 Reported by: brnrd Submitted by: dizzyy Approved by: rakuco archivers/libzip/Makefile | 9 ++++++--- archivers/libzip/distinfo | 6 +++--- archivers/libzip/files/patch-git_fd89e242 (gone) | 18 ------------------ archivers/libzip/pkg-plist | 7 +++++-- 4 files changed, 14 insertions(+), 26 deletions(-)