Bug 264084 - shells/rc missing files when upgrading
Summary: shells/rc missing files when upgrading
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-19 19:30 UTC by jakub_lach
Modified: 2022-05-21 09:38 UTC (History)
2 users (show)

See Also:


Attachments
patch to deinstallation problem for shells/rc (1.16 KB, patch)
2022-05-20 20:45 UTC, Chris Hutchinson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jakub_lach 2022-05-19 19:30:48 UTC
===>>> Creating a backup package for old version rc-1.7.4_2
Creating package for rc-1.7.4_2
pkg-static: file '/usr/local/bin/--' is missing
pkg-static: package creation failed

===>>> Package creation failed for rc-1.7.4_2!

===>>> Ignore this error  [i]
===>>> Abort update       [a]
===>>> Retry              [r]

===>>> How would you like to proceed? [i] i

Updating database digests format: 100%
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
        rc: 1.7.4_2

Number of packages to be removed: 1

The operation will free 1 MiB.
[1/1] Deinstalling rc-1.7.4_2...
[1/1] Deleting files for rc-1.7.4_2:  10%
rc-1.7.4_2: missing file /usr/local/bin/--
[1/1] Deleting files for rc-1.7.4_2:  20%
rc-1.7.4_2: missing file /usr/local/bin/--p
[1/1] Deleting files for rc-1.7.4_2:  30%
rc-1.7.4_2: missing file /usr/local/bin/-p
[1/1] Deleting files for rc-1.7.4_2: 100%

===>>> Starting check for runtime dependencies
===>>> Gathering dependency list for shells/rc from ports
===>>> No dependencies for shells/rc

===>  Installing for rc-1.7.4_3
===>  Checking if rc is already installed
===>   Registering installation for rc-1.7.4_3
Installing rc-1.7.4_3...

===>>> Upgrade of rc-1.7.4_2 to rc-1.7.4_3 succeeded
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2022-05-19 19:30:48 UTC
Maintainer informed via mail
Comment 2 Chris Hutchinson 2022-05-20 20:45:56 UTC
Created attachment 234067 [details]
patch to deinstallation problem for shells/rc

The error(s) reported are harmless. While I'm not
the Maintainer. I was the last one to touch this.
The changes I made largely carried the previous
policies forward.
However, now that you report these errors. I took
a closer look and discovered that one of those policies
was wrong. It's effectively the same error. Just repeated
for every missing link.

Problem:
The patch file used with this port hard links [ln(1)]
one file to several additional files by other names. Which
means once the target is removed all the links (correctly)
complain.

Solution:
While I probably could have created Soft links instead.
I simply chose to make literal copies for each of the
needed named files.
This is what the attached diff provides. It also replaces
the previous patch.

Sample output after patching and installing 1.7.4_2.
Then patching 1.7.4_3 and attempting an upgrade:

dev@portsdev $ make -DBATCH deinstall && make -DBATCH install
===>  Deinstalling for rc
===>   Deinstalling rc-1.7.4_2
Updating database digests format: 100%
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	rc: 1.7.4_2

Number of packages to be removed: 1

The operation will free 3 MiB.
[portsdev.localhost] [1/1] Deinstalling rc-1.7.4_2...
[portsdev.localhost] [1/1] Deleting files for rc-1.7.4_2: 100%
===>  Installing for rc-1.7.4_3
===>  Checking if rc is already installed
===>   Registering installation for rc-1.7.4_3
[portsdev.localhost] Installing rc-1.7.4_3...

dev@portsdev $

Problem solved.

@Maintainer/committer
If the Maintainer is no longer able/willing to continue maintaining
this port. Feel free to name me as Maintainer.

That's it.

Thanks!

Chris
Comment 3 jakub_lach 2022-05-20 21:26:30 UTC
(In reply to Chris Hutchinson from comment #2)

Thank you! I suspected this was probably harmless and have noticed it was the same thing, even better that it got fixed so fast :)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-05-21 09:35:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2f051a95cb1fe7e8a091c755c2ccdee3ded3ff61

commit 2f051a95cb1fe7e8a091c755c2ccdee3ded3ff61
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2022-05-21 09:31:00 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-05-21 09:35:14 +0000

    shells/rc: fix deinstallaion problem

    PR:             264084
    Reported by:    jakub_lach@mailplus.pl
    Approved by:    blanket (fix deinstallation)

 shells/rc/Makefile                |  2 +-
 shells/rc/files/patch-Makefile.am | 13 +++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2022-05-21 09:38:24 UTC
(In reply to Chris Hutchinson from comment #2)
Committed, thanks! If you take this port, send another patch to replace MAINTAINER. No feedback from current maintainer for 2 weeks, the port will be assigned to you.