Bug 264109 - misc/freebsd-doc-en FreeBSD Handbook outdated
Summary: misc/freebsd-doc-en FreeBSD Handbook outdated
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Document Engineering Group (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-20 23:12 UTC by Graham Perrin
Modified: 2022-05-31 06:10 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (doceng)


Attachments
freebsd-doc-update-d95da68.patch (5.78 KB, patch)
2022-05-21 14:23 UTC, Danilo G. Baio
dbaio: maintainer-approval? (blackend)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2022-05-20 23:12:13 UTC
From bug 258078 comment 3: 

> PDF documents are being generated every week on Mondays for now.

> … any issues with PDF documents, please open doc PRs (you can also 
> CC me). 
> 
> Thank you.

Committed 18 days ago: 

handbook: replace `gnome3` package with `gnome` … 
<https://github.com/freebsd/freebsd-doc/commit>/6d50dd7f08ad3a3847c717bd22d247ed7b7d7d0f

en-freebsd-doc-20220326,1 includes an edition of the Handbook that still mentions gnome3.

<https://old.reddit.com/r/freebsd/comments/ut1dd6/-/i9dx3ra/?context=1> for example, there was outdated advice: 

    pkg install gnome3
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2022-05-20 23:15:08 UTC
(In reply to Graham Perrin from comment #0)

> <https://github.com/freebsd/freebsd-doc/commit>
> /6d50dd7f08ad3a3847c717bd22d247ed7b7d7d0f

Sorry, that was a casualty of bug 250699. The URL should have been: 

<https://github.com/freebsd/freebsd-doc/commit/6d50dd7f08ad3a3847c717bd22d247ed7b7d7d0f>
Comment 2 Danilo G. Baio freebsd_committer freebsd_triage 2022-05-21 14:23:21 UTC
Created attachment 234082 [details]
freebsd-doc-update-d95da68.patch

misc/freebsd-doc-*: Update to rev. d95da68 from the FreeBSD docset

Move MASTER_SITES to GitHub, it simplifies future updates.

Add Indonesian translation port.
Comment 3 Danilo G. Baio freebsd_committer freebsd_triage 2022-05-21 14:23:36 UTC
Hi Marc. Could you take a look at this patch? 
It's all building fine through poudriere.

Thanks.
Comment 4 Marc Fonvieille freebsd_committer freebsd_triage 2022-05-26 10:19:26 UTC
(In reply to Danilo G. Baio from comment #3)
I'll look at it, it was already in my future update with another change.

I disagree with the github as master site since the distfile is just a partial part of the repo (without useless files to reduce space/bandwidth usage).

The aim of the ports is not to follow every day changes, it's not possible and there is the website for that.
Comment 5 Danilo G. Baio freebsd_committer freebsd_triage 2022-05-26 11:23:56 UTC
(In reply to Marc Fonvieille from comment #4)

SIZE (freebsd-doc-20220326.tar.gz) = 97658560
SIZE (freebsd-freebsd-doc-20220521-d95da68_GH0.tar.gz) = 97297360

GitHub Archive is slightly lesser than the current one.
And fetching it from GitHub will probably save more project resources (space/bandwidth) than hosting it on freefall.

And I'm not proposing updating this port every day.

This will also save time when updating it; you will only need to change a git tag (at least) in the Makefile.

Regards.
Comment 6 Marc Fonvieille freebsd_committer freebsd_triage 2022-05-27 08:46:02 UTC
(In reply to Danilo G. Baio from comment #5)
In fact current distfile "should be" (a bug during my last rolls) about 31M.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-05-27 11:28:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=377a25d0ac0cb934aee0f9b784d4b2bf4bfd698b

commit 377a25d0ac0cb934aee0f9b784d4b2bf4bfd698b
Author:     Marc Fonvieille <blackend@FreeBSD.org>
AuthorDate: 2022-05-27 11:15:59 +0000
Commit:     Marc Fonvieille <blackend@FreeBSD.org>
CommitDate: 2022-05-27 11:28:12 +0000

    misc/freebsd-doc-*: Update to rev. 719bd81 from the FreeBSD docset

    - Update to rev. 719bd81 from the FreeBSD docset (1)
    - Add a check for PDF build dependencies (2)
    PR:             264109 (1), 262820 (2)
    Reported by:    Graham Perrin <grahamperrin@gmail.com> (1)
                    Alessandro Sagratini <ale_sagra@hotmail.com> (2)

 misc/freebsd-doc-en/Makefile | 6 +++++-
 misc/freebsd-doc-en/distinfo | 6 +++---
 2 files changed, 8 insertions(+), 4 deletions(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-05-27 11:28:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=88426dd061d42eaaf9a12dd53f01faa52cde3613

commit 88426dd061d42eaaf9a12dd53f01faa52cde3613
Author:     Marc Fonvieille <blackend@FreeBSD.org>
AuthorDate: 2022-05-27 11:21:45 +0000
Commit:     Marc Fonvieille <blackend@FreeBSD.org>
CommitDate: 2022-05-27 11:28:12 +0000

    misc/freebsd-doc-id: Add new port (Indonesian documentation)

    Following update to rev. 719bd81 from the FreeBSD docset, add
    Indonesian documentation port.

    PR:             264109
    Reported by:    Graham Perrin <grahamperrin@gmail.com>

 misc/Makefile                                   |  1 +
 misc/freebsd-doc-id/Makefile (new)              | 12 ++++++++++++
 misc/freebsd-doc-id/pkg-plist.html (new)        |  1 +
 misc/freebsd-doc-id/pkg-plist.html-common (new) |  9 +++++++++
 misc/freebsd-doc-id/pkg-plist.pdf (new)         |  1 +
 5 files changed, 24 insertions(+)
Comment 9 Marc Fonvieille freebsd_committer freebsd_triage 2022-05-30 16:17:41 UTC
I committed a slightly different version of your patch.
Thanks.
Comment 10 Graham Perrin freebsd_committer freebsd_triage 2022-05-31 06:10:57 UTC
I now have a recent edition of the Handbook at: 

/usr/local/share/doc/freebsd/en/books/handbook/handbook_en.pdf

Thanks!