Bug 264262 - sysutils/edk2: fix build with gcc12
Summary: sysutils/edk2: fix build with gcc12
Status: Closed DUPLICATE of bug 263543
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-26 18:48 UTC by Oleg Sidorkin
Modified: 2022-05-28 22:38 UTC (History)
4 users (show)

See Also:
osidorkin: maintainer-feedback?

Attachments
patch to fix build of sysutils/edk2 with gcc12 (2.70 KB, patch)
2022-05-26 18:48 UTC, Oleg Sidorkin 		osidorkin: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sidorkin 2022-05-26 18:48:33 UTC 
Created attachment 234235 [details]
patch to fix build of sysutils/edk2 with gcc12

Backport 2 upstreamed patches and fix ar path.

While here pet portlint
Comment 1 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-05-26 18:57:57 UTC 
Thank you very much Oleg for your patch, Oleg.

Could you please check if your patch also works with GCC 11? There is some work in progress to update the default version of GCC on FreeBSD from GCC 10 to GCC 11 and sysutils/edk2 is bloking the process.

Please see bug #263543.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2022-05-27 00:13:52 UTC 
^Triage: Close as duplicate of bug 263543 after updating its summary (scope) to GCC > 11

@Aleg Please attach your patches in that issue thank you!

*** This bug has been marked as a duplicate of bug 263543 ***
Comment 3 Oleg Sidorkin 2022-05-28 10:33:35 UTC 
(In reply to Lorenzo Salvadore from comment #1)
edk2@bhyve port builds fine for me with GCC11 both patched and unpatched
Comment 4 Oleg Sidorkin 2022-05-28 19:53:06 UTC 
(In reply to Lorenzo Salvadore from comment #1)
At least it builds for me with gcc11. Have n(In reply to Kubilay Kocak from comment #2)

That's different problem: GCC11 build problem was fixed by update of edk2, and GCC12 builds were fixed in upstream trunk (with patched I'm trying to add to the port).
Comment 5 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-05-28 22:38:19 UTC 
(In reply to Oleg Sidorkin from comment #3)

Thank you very much for your feedback.

As for the bug duplication, indeed your update is a different problem than the build failure with GCC 11, however the summary of bug #263543 has been edited so that it now deals with the build for GCC > 11 (not even >= 11, as it seems the case = 11 has already been fixed) and this bug has been closed, so I recommend you to follow koobs' suggestion and attach your patch to the new issue.

I guess the reason to move the discussion there is the fact that a discussion about edk2 and GCC had already started.

Moreover, whenever you ask for maintainer feedback or maintainer approval, please remember to add the maintainer email address as requestee, otherwise you risk that your request gets unnoticed.