Created attachment 234260 [details] Patch to fix and extend FreeBSD support in py-fido2 Upstream broke FreeBSD support a while ago by accident, when removing the dependency on py-uhid-freebsd. This patch, which was already accepted by highly supportive and very responsive upstream, brings back FreeBSD support with classic uhid(4) and adds support for the new hidraw(4), usbhid(3) based driver. Patch suitable for use with `git am`.
Thanks for this Michael. Can you confirm this passes poudriere and `make test` on at least the default python version and one non default version Happy to accept on that QA. Great stuff sorting this out upstream
(In reply to Kubilay Kocak from comment #1) I can confirm that all of these pass on amd64: Python 3.8 (default): [x] poudriere testport [x] poudriere bulk [x] make test [x] make test with an actual device plugged in (runs one more test) Python 3.9: [x] poudriere testport [x] poudriere bulk [x] make test
(In reply to Michael Gmelin from comment #2) Thank you, all yours champ!
Comment on attachment 234260 [details] Patch to fix and extend FreeBSD support in py-fido2 Approved by: koobs (python, maintainer) MFH: 2022Q2
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ce57b8b96961901188c60319459cfb5fcea13f03 commit ce57b8b96961901188c60319459cfb5fcea13f03 Author: Michael Gmelin <grembo@FreeBSD.org> AuthorDate: 2022-05-27 09:27:56 +0000 Commit: Michael Gmelin <grembo@FreeBSD.org> CommitDate: 2022-06-07 11:51:57 +0000 security/py-fido2: Fix and extend FreeBSD support This unbreaks FreeBSD support in general and adds support for FreeBSD 13's optional hidraw(4) driver. See https://github.com/Yubico/python-fido2/pull/139 PR: 264281 Approved by: koobs (python, maintainer) security/py-fido2/Makefile | 1 + .../files/patch-fido2_hid_freebsd.py (new) | 222 +++++++++++++++++++++ 2 files changed, 223 insertions(+)
A commit in branch 2022Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=afdc136ee424cd6159b4e77d3b56d5a9f32669c9 commit afdc136ee424cd6159b4e77d3b56d5a9f32669c9 Author: Michael Gmelin <grembo@FreeBSD.org> AuthorDate: 2022-05-27 09:27:56 +0000 Commit: Michael Gmelin <grembo@FreeBSD.org> CommitDate: 2022-06-07 11:56:27 +0000 security/py-fido2: Fix and extend FreeBSD support This unbreaks FreeBSD support in general and adds support for FreeBSD 13's optional hidraw(4) driver. See https://github.com/Yubico/python-fido2/pull/139 PR: 264281 Approved by: koobs (python, maintainer) (cherry picked from commit ce57b8b96961901188c60319459cfb5fcea13f03) security/py-fido2/Makefile | 1 + .../files/patch-fido2_hid_freebsd.py (new) | 222 +++++++++++++++++++++ 2 files changed, 223 insertions(+)