Bug 264486 - audio/libmad: 0.16.0 breaks at least audio/madplay and multimedia/mplayer
Summary: audio/libmad: 0.16.0 breaks at least audio/madplay and multimedia/mplayer
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords: regression
Depends on: 264442
Blocks:
  Show dependency treegraph
 
Reported: 2022-06-05 20:25 UTC by gja822
Modified: 2022-06-25 19:47 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)
riggs: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gja822 2022-06-05 20:25:11 UTC
Since updating libmad to "secret" version 16.0 (officially it is 15.2 on authors' site?) it stopped working rightly in madplay (sound is distorted and slowed) and stopped working at all in mplayer (after rebuilding it, of course).

I am on FreeBSD-12 stable amd64 if it matters.
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2022-06-08 07:07:49 UTC
This repo (https://github.com/tenacityteam/libmad/commits/main) looks weird. There are only a few changes for various build systems, but I don't see anything that should substantially alter the playback experience compared to the 0.15.1b version (which is the latest libmad version via underbit.com).

Maybe Daniel (cc'ed) can provide some input, he's contributor to this repo.
Comment 2 gja822 2022-06-08 09:19:22 UTC
(In reply to Thomas Zander from comment #1)

Well, here it is madplay-0.15.2b.tar (despite the number in the address)

https://sourceforge.net/projects/mad/files/libmad/0.15.1b/
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-06-08 21:07:56 UTC
Hi,

I only tested decoding which worked in some cases unfortunately. In the linked PR there's a GitHub link to a PR and discussion with upstream how to go about fixing it. Upstream is since long dead and we're struggling keeping track of all CVEs and patches from various source so this is hopefully a good trade-off.

Out of curiosity, from what I can tell libmad support is disabled in mplayer port so why are you still building it?

Best regards,
Daniel
Comment 4 gja822 2022-06-09 09:37:27 UTC
(In reply to Daniel Engberg from comment #3)
Well, 0.15.2b somehow worked for me, either in madplay or in mplayer.

And about my approach to an mplayer. I usually build it manually from SVN, not from ports because the port is somehow can be outdated and because it has hard-disabled (for maintenance sake?) almost all non-ffmpeg variants of decoders (and most of them work just fine without ffmpeg layer). I do not like this behavior, since I have ffplay for what uses ffmpeg.
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-06-09 10:11:32 UTC
I plan to downgrade this port back to 0.15.1b temporarily but keep PORTVERSION as 0.16.0 for now to avoid PORTEPOCH.
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2022-06-09 10:27:46 UTC
(In reply to Po-Chuan Hsieh from comment #5)
fwiw, this is about to get fixed soon in upstream repo, https://github.com/tenacityteam/libmad/pull/3

If you plan to downgrade please make sure to include all patches from at least Fedora, Debian and possibly other repos. Please also keep the naming of pc file
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2022-06-09 18:01:59 UTC
PR is now updated, if possible please test
Comment 8 gja822 2022-06-09 18:16:38 UTC
(In reply to Daniel Engberg from comment #6)

So, it is a problem of migration to cmake (again), isn't it. At least partially.
Comment 9 Daniel Engberg freebsd_committer freebsd_triage 2022-06-22 07:21:40 UTC
If possible please try the patch attached in PR 264442 (Patch for libmad v2), this should fix libmad
Comment 10 gja822 2022-06-22 07:39:15 UTC
(In reply to Daniel Engberg from comment #9)
Yes, it seems that the proposed patch fixes the bug, thank you!

(And I do realized that libmad performs better than mpg123 due to quality of low rate audio, somehow.)
Comment 11 Daniel Engberg freebsd_committer freebsd_triage 2022-06-25 19:47:33 UTC
Fixed as of e0b51d322893b00805bd3e233476f5983b692894