Make it possible to build webalizer without DNS support. While we're here, sort OPTIONS.
Created attachment 234769 [details] patch
1) Sorting options is a bad idea. The options are ordered by function groups: databases, charsets, patches. 2) DNS lookups are disabled by default in webalizer.conf There are no external dependencies for this option. Please explain why do your need to build a binary without? 3) The patch is incomplete. Whithout DNS you don't need the "webazolver" binary.
Created attachment 234772 [details] revised patch I have a system is able to sustain more than 2K PTR queries/sec for 20 minutes starting at midnight (when I run webalizer). DNS.README lead me to believe the only want to disable PTR lookups was at compile time: Note: The Reverse DNS feature may be enabled or disabled at compile time. DNS lookup code is enabled by default. You can run The Webalizer using the '-vV' command line options to determine what options are enabled in the version you are using.
4) wcmgr is only for the DNS cache. I am not sure the patched port does compile. 5) manpage: REVERSE DNS LOOKUPS The Webalizer fully supports IPv4 and IPv6 DNS lookups, and maintains a cache of those lookups to reduce processing the same addresses in subsequent runs. The cache file can be created at run-time, or may be created before running the webalizer using either the stand alone 'webazolver' program, or The Webalizer (DNS) Cache file manager program 'wcmgr'. In order to perform reverse lookups, a DNSCache file must be specified, either on the command line or in a configuration file. Even for high performance, running without "DNSCache" in config file and CLI arguments is sufficient. The patch does only add complexity for no real benefit.
Created attachment 234795 [details] revised patch Only install wcmgr when DNS.
Created attachment 234796 [details] build log poudriere build log for 13.1-RELEASE
More regressions: 6) The options GEOIP and GEODB are broken wiithout DNS Possible fix is to add *_IMPLIES= 7) Slave ports */geolizer need to be extended as well. Possible fix extends OPTIONS_DEFAULT there. 8) manpage "wcmgr.1.gz" should not be included. Possible fix: -LMAN1= ${PKGNAMEPREFIX}webalizer.1 ${PKGNAMEPREFIX}wcmgr.1 +LMAN1= ${PKGNAMEPREFIX}webalizer.1 +.if ${PORT_OPTIONS:MDNS} +LMAN1+= ${PKGNAMEPREFIX}wcmgr.1 +.endif
Ok, I give up.