Bug 264769 - comms/freedv: update to 1.7.0
Summary: comms/freedv: update to 1.7.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Diane Bruce
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2022-06-19 12:01 UTC by lu9dce
Modified: 2022-08-04 21:51 UTC (History)
2 users (show)

See Also:
vishwin: maintainer-feedback+


Attachments
update for freedv codec and lpcnet (2.43 KB, patch)
2022-06-19 19:07 UTC, Diane Bruce
no flags Details | Diff
Oops wrong patch attached (2.43 KB, patch)
2022-06-19 19:19 UTC, Diane Bruce
no flags Details | Diff
Third time patch is right (8.14 KB, patch)
2022-06-19 19:22 UTC, Diane Bruce
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description lu9dce 2022-06-19 12:01:51 UTC
https://github.com/drowe67/freedv-gui/releases/tag/v1.7.0

released this 05 Feb 2022

for the new hamlib?

tks 73

lu9dce
Comment 1 lu9dce 2022-06-19 12:14:47 UTC
confirmed the new freedv
compiles perfectly
with the hamlib 4

please update the port

73

https://i.imgur.com/ABgDURy.png
Comment 2 Charlie Li freebsd_committer freebsd_triage 2022-06-19 13:36:04 UTC
But does it run as intended? (Screenshot shows that it opened up but not actual operation)

We will also need a patch attached here or phab so others interested can try it too.
Comment 3 lu9dce 2022-06-19 13:42:28 UTC
(In reply to Charlie Li from comment #2)

it works
at that moment in the image the radio was not on
do not use any patch

https://i.imgur.com/VACgIbK.png

sorry it's on the frequency of ft8
looks at the waterfall
Comment 4 Charlie Li freebsd_committer freebsd_triage 2022-06-19 13:45:00 UTC
(In reply to lu9dce from comment #3)
Better.

Still needs a patch against the ports tree (not against FreeDV itself, haha). We  would like to easily credit whoever started and continued the efforts to updating and getting it working on here.
Comment 5 lu9dce 2022-06-19 13:52:03 UTC
(In reply to Charlie Li from comment #4)

I tried with two sound cards
the ptt via serial port
/dev/cuau0
It's going, it's going well
where indicated the serial port took something from tty
manually change it to /dev/cuau0

but the program as it is

what I could not inform you is with a cat
i have a ts120 :(
Comment 6 Diane Bruce freebsd_committer freebsd_triage 2022-06-19 19:07:48 UTC
Created attachment 234792 [details]
update for freedv codec and lpcnet

I worked on this some months ago but got time constrained or something came up. freedv split out lpcnet and that part is in this update. I was about to go look at freedv again this week but this PR came in. ;) the update for lpcnet and codec2 may be out of date too. I just updated freedv to 1.7.0 locally from 1.6.2
Comment 7 Diane Bruce freebsd_committer freebsd_triage 2022-06-19 19:19:31 UTC
Created attachment 234793 [details]
Oops wrong patch attached

oops the last patch missed the lpcnet which is a new port we will have to add to the tree.
Comment 8 Diane Bruce freebsd_committer freebsd_triage 2022-06-19 19:22:32 UTC
Created attachment 234794 [details]
Third time patch is right

The third times the charm. Forgot to put new diff on this computer after regenerating it elsewhere.
Comment 9 lu9dce 2022-06-19 19:30:42 UTC
well it looks like it's going

what to watch for hamradio
is JTDX the new version goes well with the hamlib
and it almost compiles me but I don't know how to
change things in the code of the program

LZ2HV has already been added with mshv
and G8BPQ with many programs for packet in freebsd

that compile perfectly and the ports are missing

I think that with JTDX the radio part would be very complete...
taking into account that we are few
it's more than i expected

with all my heart the effort is appreciated
Comment 10 Diane Bruce freebsd_committer freebsd_triage 2022-08-02 18:37:58 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263061 is now outdated
Comment 11 commit-hook freebsd_committer freebsd_triage 2022-08-04 21:50:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1731b077ffd7478f98d032ab3ed65167a102d276

commit 1731b077ffd7478f98d032ab3ed65167a102d276
Author:     Diane Bruce <db@FreeBSD.org>
AuthorDate: 2022-08-04 21:46:32 +0000
Commit:     Diane Bruce <db@FreeBSD.org>
CommitDate: 2022-08-04 21:46:32 +0000

    comms/freedv: Update to v1.7.0

    Unbreaks port

    upstream notes:
    Bugfixes:

        Resolves issue with waterfall appearing garbled on some systems. (PR #205)
        Resolves issue with Restore Defaults restoring previous settings on exit. (PR #207)
        Resolves issue with some sound valid sound devices causing PortAudio errors during startup checks. (PR #192)

    Enhancements:

        Removes requirement to restart FreeDV after using Restore Defaults. (PR #207)
        Hides frequency display on main window unless PSK Reporter reporting is turned on. (PR #207)
        Scales per-mode squelch settings when in multi-RX mode to reduce unwanted noise. (PR #186)
        Single-thread mode is now the default when multi-RX is turned on. (PR #175)
        Makes multi-RX mode the default. (PR #175)
        Mic In/Speaker Out volume controls added to Filter window. (PR #208)
        Cleans up UI for filters and makes the dialog non-modal. (PR #208)
        Adds optional support for PulseAudio on Linux systems. (PR #194)

    Documentation:

        Resolves issue with PDF image placement. (PR #203)

    Build System:

        Uses more portable way of referring to Bash in build scripts. (PR #200)
        User manual now installed along with executable. (PR #187)
        macOS app bundle generated by CMake instead of manually. (PR #184)
        Fail as soon as a step in the build script fails. (PR #183)

    PR:             ports/264769
    Reported by:    castilloeduardo@outlook.com.ar
    Tested by:      castilloeduardo@outlook.com.ar

 comms/freedv/Makefile                                | 19 +++++++++++--------
 comms/freedv/distinfo                                |  6 +++---
 comms/freedv/files/patch-CMakeLists.txt (gone)       | 18 ------------------
 comms/freedv/files/patch-src__fdmdv2_main.cpp (gone) | 15 ---------------
 comms/freedv/pkg-descr                               |  2 +-
 5 files changed, 15 insertions(+), 45 deletions(-)