Bug 264866 - audio/mp3splt: segmentation fault
Summary: audio/mp3splt: segmentation fault
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-24 08:01 UTC by Slawomir Wojciech Wojtczak
Modified: 2022-08-16 21:46 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (citrin)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Slawomir Wojciech Wojtczak 2022-06-24 08:01:21 UTC
As described in title - added from 'Latest' branch of pkg(8) packages.

# pkg info audio/mp3splt
mp3splt-2.6.2
Name           : mp3splt
Version        : 2.6.2
Installed on   : Fri Jun 24 09:54:21 2022 CEST
Origin         : audio/mp3splt
Architecture   : FreeBSD:13:amd64
Prefix         : /usr/local
Categories     : audio
Licenses       : GPLv2
Maintainer     : citrin@citrin.ru
WWW            : http://mp3splt.sourceforge.net/
Comment        : Utility to split MP3 and Ogg files (via CUE sheets)
Options        :
        NLS            : on
Shared Libs required:
        libmp3splt.so.0
        libintl.so.8
Annotations    :
        FreeBSD_version: 1300139
        cpe            : cpe:2.3:a:mp3splt_project:mp3splt:2.6.2:::::freebsd13:x64
        repo_type      : binary
        repository     : FreeBSD
Flat size      : 112KiB
Description    :
Mp3Splt is a command line utility to split mp3 and ogg files selecting a begin
and an end time position, without decoding. It's very useful to split large
mp3/ogg to make smaller files or to split entire albums to obtain original
tracks. If you want to split an album, you can select split points and
filenames manually or you can get them automatically from CDDB (Internet or a
local file) or from .cue files.  Otherwise if you have a file created either
with Mp3Wrap or AlbumWrap you can extract tracks just in few seconds. Supports
VBR mp3.

WWW: http://mp3splt.sourceforge.net/



% time mp3splt -f -t 5.0 -a -d . Catherine.mp3   
mp3splt 2.6.2 (09/11/14) - using libmp3splt 0.9.2
        Matteo Trotta <mtrotta AT users.sourceforge.net>
        Alexandru Munteanu <m AT ioalex.net>
THIS SOFTWARE COMES WITH ABSOLUTELY NO WARRANTY! USE AT YOUR OWN RISK!
 Processing file 'Catherine.mp3' ...
 info: file matches the plugin 'mp3 (libmad)'
 info: found Xing or Info header. Switching to frame mode... 
 info: MPEG 1 Layer 3 - 44100 Hz - Joint Stereo - FRAME MODE - Total time: 694m.03s
 Working with SILENCE AUTO-ADJUST (Threshold: -48.0 dB Gap: 30 sec Offset: 0.80 Min: 0.00 sec)
 info: starting time mode split
zsh: segmentation fault  mp3splt -f -t 5.0 -a -d . Catherine.mp3
mp3splt -f -t 5.0 -a -d . Catherine.mp3  0.02s user 0.01s system 47% cpu 0.066 total



% time mp3splt -t 5.0 -a -d . Catherine.mp3 
mp3splt 2.6.2 (09/11/14) - using libmp3splt 0.9.2
        Matteo Trotta <mtrotta AT users.sourceforge.net>
        Alexandru Munteanu <m AT ioalex.net>
THIS SOFTWARE COMES WITH ABSOLUTELY NO WARRANTY! USE AT YOUR OWN RISK!
 Processing file 'Catherine.mp3' ...
 info: file matches the plugin 'mp3 (libmad)'
 info: found Xing or Info header. Switching to frame mode... 
 info: MPEG 1 Layer 3 - 44100 Hz - Joint Stereo - FRAME MODE - Total time: 694m.03s
 Working with SILENCE AUTO-ADJUST (Threshold: -48.0 dB Gap: 30 sec Offset: 0.80 Min: 0.00 sec)
 info: starting time mode split
zsh: segmentation fault  mp3splt -t 5.0 -a -d . Catherine.mp3  
mp3splt -t 5.0 -a -d . Catherine.mp3  0.01s user 0.02s system 46% cpu 0.053 total
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-06-29 22:11:33 UTC
Seeing that upstream is dead since a few years back I'd rather see that we remove it rather. Not sure what exactly you want to do but can use ffmpeg to detect silent parts and split/trim audio without re-encoding.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-06-29 22:14:04 UTC
Heh... lets try that again,

Seeing that upstream is dead since a few years back I'd rather see that we remove mp3splt rather than keeping it on life support. Not sure what exactly you want to do but you can use ffmpeg to detect silent parts and split/trim audio without re-encoding.
Comment 3 Slawomir Wojciech Wojtczak 2022-06-29 22:30:26 UTC
Hi,

I already created a script that does mostly the same what 'mp3splt' did:

- https://vermaden.wordpress.com/2022/06/25/split-audio-files-into-parts/

Not sure what to do with 'audio/mp3splt' port either ... I just submitted that it currently does not work.

Regards.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-12 06:44:47 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b5d94a6d52c79af26f9a4527423d23d427825f89

commit b5d94a6d52c79af26f9a4527423d23d427825f89
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-07-11 20:41:38 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-07-12 06:43:19 +0000

    audio/mp3splt: Mark BROKEN (doesn't run), deprecate and set expiration date to 2022-09-30

    Mark BROKEN as program segfaults, while at it deprecate and set
    expiration date as upstream is dead and last release was back in 2014

    PR:             264866
    Reported by:    Slawomir Wojciech Wojtczak <vermaden@interia.pl>
    Approved by:    citrin@citrin.ru (maintainer timeout, 2+ weeks)

 audio/mp3splt/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-07-12 06:48:42 UTC
Thanks for reporting!
Comment 6 Bryan Erickson 2022-08-12 15:49:53 UTC
I removed the broken port flag in the MakeFile compiles / installed it. For my initial testing it appeared to work fine.

Development appears to have moved here: https://github.com/mp3splt/mp3splt as per https://sourceforge.net/projects/mp3splt/

I also ran the command below (using the version in ports) that had failed for Swaomir and can't recreate it:

$ time mp3splt -t 5.0 -a -d . large_audio_file.mp3 
mp3splt 2.6.2 (09/11/14) - using libmp3splt 0.9.2
        Matteo Trotta <mtrotta AT users.sourceforge.net>
        Alexandru Munteanu <m AT ioalex.net>
THIS SOFTWARE COMES WITH ABSOLUTELY NO WARRANTY! USE AT YOUR OWN RISK!
 Processing file 'large_audio_file.mp3' ...
 info: file matches the plugin 'mp3 (libmad)'
 info: MPEG 1 Layer 3 - 44100 Hz - Mono - FRAME MODE - Total time: 100m.37s
 Working with SILENCE AUTO-ADJUST (Threshold: -48.0 dB Gap: 30 sec Offset: 0.80 Min: 0.00 sec)
 info: starting time mode split
   File "./large_audio_file_000m_00s__005m_00s.mp3" created                  
   File "./large_audio_file_005m_00s__010m_00s.mp3" created                  
   File "./large_audio_file_010m_00s__015m_00s.mp3" created                  
   File "./large_audio_file_015m_00s__020m_00s.mp3" created                  
   File "./large_audio_file_020m_00s__025m_00s.mp3" created                  
   File "./large_audio_file_025m_00s__030m_00s.mp3" created                  
   File "./large_audio_file_030m_00s__035m_00s.mp3" created                  
   File "./large_audio_file_035m_00s__040m_00s.mp3" created                  
   File "./large_audio_file_040m_00s__045m_00s.mp3" created                  
   File "./large_audio_file_045m_00s__050m_00s.mp3" created                   
   File "./large_audio_file_050m_00s__055m_00s.mp3" created                   
   File "./large_audio_file_055m_00s__060m_00s.mp3" created                   
   File "./large_audio_file_060m_00s__065m_00s.mp3" created                   
   File "./large_audio_file_065m_00s__070m_00s.mp3" created                   
   File "./large_audio_file_070m_00s__075m_00s.mp3" created                   
   File "./large_audio_file_075m_00s__080m_00s.mp3" created                   
   File "./large_audio_file_080m_00s__085m_00s.mp3" created                   
   File "./large_audio_file_085m_00s__090m_00s.mp3" created                   
   File "./large_audio_file_090m_00s__095m_00s.mp3" created                   
   File "./large_audio_file_095m_00s__100m_00s.mp3" created                   
   File "./large_audio_file_100m_00s__100m_37s_70h.mp3" created               
 Processed 231132 frames - Sync errors: 0                                  
 time split ok
        1.71 real         1.61 user         0.08 sys

I don't have a strong feeling about this if ffmpeg can do the same type of cutting without re-encoding, but I'm not sure if the feature-set is 1-1.
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2022-08-16 21:46:45 UTC
Seems to work for me as well on 13.1-STABLE (amd64) so lets keep it in tree for now. Thanks for reporting!