Created attachment 235011 [details] bump deluge to 2.1.0, removes obsolete patches Update deluge to 2.1.0 There is no way to link directly to the 2.1.0 changelog but you can find it on this page, currently in the top: https://deluge.readthedocs.io/en/latest/changelog.html
Created attachment 235013 [details] bump deluge to 2.1.0, removes obsolete patches ticked the patch checkbox this time
Hmm, actually libtorrent-rasterbar is the show stopper right now. It should be fixed first to test deluge update. There is also report that deluge is broken with latest pyopenssl in the ports, that is indeed require more fresh cryptography package.
Here is the github report https://github.com/arvidn/libtorrent/issues/6890
Why is Deluge available for 12.x on every platform except for amd64(i.e. the only one it is likely to be used on in FreeBSD).
(In reply to Tom Pfaffe from comment #4) I suppose it's because of absense of libtorrent-rasterbar package on these architectures. According to table there: https://www.freshports.org/net-p2p/py-libtorrent-rasterbar/ It's vital dependency for deluge.
Keyword: patch or patch-ready – in lieu of summary line prefix: [patch] * bulk change for the keyword * summary lines may be edited manually (not in bulk). Keyword descriptions and search interface: <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>
(In reply to Ruslan Makhmatkhanov from comment #2) I downgraded libtorrent-rasterbar locally and it installs fine and then deluge-cli installs fine too. I don't know how ports are managed, but it feels unintuitive to me that the upgrade of libtorrent-rasterbar from 1.2.14 to 1.2.16 (via 2.0.6-27) is important enough that breakage of a downstream package (deluge-cli in this case) is considered OK. The changelog between those two releases: https://github.com/arvidn/libtorrent/releases/tag/v1.2.15 https://github.com/arvidn/libtorrent/releases/tag/v1.2.16 I have deluge-cli 2.1.1 running without issues against libtorrent-rasterbar 1.2.14. About the pyopenssl problem, I don't have anything to add except that it does not affect me for some reason.
Created attachment 237822 [details] downgrade libtorrent-rasterbar
Created attachment 237823 [details] upgrade deluge to 2.1.1 net-p2p/deluge-cli: update to 2.1.1 fix service file issues: - long options to make it easier to read - remove deprecated -f/--fork option (it's now default and there is no way to explicitly negate the new option --do-not-daemonize) - use *_confdir variable in command_args - remove setproctitle dependency to allow stop/restart of service fix build issues: - replace slimit with rjsmin for javascript minification for web ui - depend on py-libtorrent-rasterbar>=1.2 (required for deluge >= 2.1) - make PY_PILLOW dependency optional for cli and required for ui (default include)
What do we need to get this patch (237823) from Joakim Bergman moving.
Created attachment 238177 [details] net-p2p/libtorrent-rasterbar: update to 1.2.18 I managed to fix the build issues with libtorrent 1.2.15+
Created attachment 238178 [details] net-p2p/deluge-cli: update to 2.1.1 I made PYPILLOW an optional dependency in this patch, but added it as a strict dependency on the GUI port. It speeds up builds and does not require a bunch of graphics/X libraries that may not be otherwise needed on a server.
I created a separate bug report/patch for the libtorrent-rasterbar changes if that makes things move along easier. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267866
Created attachment 239309 [details] net-p2p/libtorrent-rasterbar: fix python bindings updated patch after libtorrent-rasterbar was updated to 1.2.18
Created attachment 242032 [details] net-p2p/libtorrent-rasterbar: fix python bindings rebased on 08f6e47c647f (most recent HEAD on 2023-05-07)
Created attachment 242033 [details] net-p2p/deluge-cli: update to 2.1.1 rebased on 08f6e47c647f (most recent HEAD on 2023-05-07)
Created attachment 242034 [details] security/py-openssl: update to 21.0.0 this is to make devel/py-twisted work
I have been running variants of these patches locally for almost a year now without issues. There has been no actionable feedback from maintainer since 2022-07-22 (and that was addressed as well as could be).
Maintainer timeout. Return to pool.
Adding maintainers of two of the patched ports in this PR.
The change in net-p2p/{,py-}libtorrent-rasterbar is approved.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3773dbe7e18982a764e45c8bb0d8a4551be2febc commit 3773dbe7e18982a764e45c8bb0d8a4551be2febc Author: Joakim Bergman <jocke@gipset.se> AuthorDate: 2023-06-18 17:11:30 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-06-21 14:29:47 +0000 net-p2p/{,py-}libtorrent-rasterbar: update to 1.2.18 And fix python bindings in preparation for update of net-p2p/deluge-cli. PR: 264970 Reported by: jocke@gipset.se Approved by: yuri@ (maintainer) net-p2p/libtorrent-rasterbar/Makefile | 3 +++ net-p2p/libtorrent-rasterbar/pkg-plist | 1 + net-p2p/py-libtorrent-rasterbar/Makefile | 14 ++++++++------ net-p2p/py-libtorrent-rasterbar/distinfo | 6 +++--- 4 files changed, 15 insertions(+), 9 deletions(-)
(In reply to Yuri Victorovich from comment #21) Thank you so much for the help! :) Is there anything I can do to help get the last two commits approved? I can understand the security/py-openssl changes are more sensitive (and I would really rather not change them but it could not be helped) but the deluge one should be less sensitive. Thanks! Jocke
(In reply to Joakim Bergman from comment #23) This went into maintainer timeout. I'll take care of it.
(In reply to Robert Clausecker from comment #24) Thank you! Do you have any guidance on the PY_PILLOW runtime dependency? I want to make it opt-in, since users who install the Deluge CLI explicitly, not through the Deluge GUI port, have no need for it. I made it opt-out to be backwards compatible and changed the Deluge GUI port to require it explicitly. I can quickly provide another patch with opt-in if approved. Thanks! Jocke
(In reply to Joakim Bergman from comment #25) I think it's better to keep it opt-out for now as you are not the maintainer. Perhaps you could ask rm@ if he would like to grant maintainership to you?
py-openssl maintainer has been privately contacted. FWIW I run some build tests with the patch for py-openssl: 13_2amd64 done [OK] 08:41:41 Building www/py-scrapy for 13_2amd64... 13_2amd64 done [OK] 08:44:49 Building www/py-google-api-python-client for 13_2amd64... 13_2amd64 done [OK] 08:55:58 Building www/py-aioquic for 13_2amd64... 13_2amd64 done [OK] 08:57:05 Building www/py-autobahn for 13_2amd64... 13_2amd64 done [OK] 09:02:10 Building www/mitmproxy for 13_2amd64... 13_2amd64 done [FAILED] 09:05:17 <--- Nothing related. A failed dependency Building www/butterfly for 13_2amd64... 13_2amd64 done [OK] 09:06:15 Building sysutils/py-azure-cli-core for 13_2amd64... 13_2amd64 done [OK] 09:12:42 Building sysutils/py-azure-cli for 13_2amd64... 13_2amd64 done [OK] 09:51:28 Building security/py-yubikey-manager for 13_2amd64... 13_2amd64 done [OK] 09:58:52 Building security/py-webauthn for 13_2amd64... 13_2amd64 done [OK] 10:00:09 Building security/py-trustme for 13_2amd64... 13_2amd64 done [OK] 10:00:43 Building security/py-sslyze for 13_2amd64... 13_2amd64 done [OK] 10:06:58 Building security/py-requests-credssp for 13_2amd64... 13_2amd64 done [OK] 10:07:55 Building security/py-pysaml2 for 13_2amd64... 13_2amd64 done [OK] 10:10:06 Building security/py-pysaml24 for 13_2amd64... 13_2amd64 done [OK] 10:11:36 Building security/py-pysaml26 for 13_2amd64... 13_2amd64 done [OK] 10:12:47 Building security/py-pyelliptic for 13_2amd64... 13_2amd64 done [OK] 10:13:21 Building security/py-josepy for 13_2amd64... 13_2amd64 done [OK] 10:13:56 Building security/py-gpsoauth for 13_2amd64... 13_2amd64 done [OK] 10:15:23 Building security/py-certbot-nginx for 13_2amd64... 13_2amd64 done [OK] 10:18:47 Building security/py-cert-human for 13_2amd64... 13_2amd64 done [OK] 10:19:22 Building security/py-asyncssh for 13_2amd64... 13_2amd64 done [OK] 10:20:02 Building security/py-acme for 13_2amd64... 13_2amd64 done [OK] 10:20:38
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=36e12132351b83f934c3ea4cb6d576d656c542f9 commit 36e12132351b83f934c3ea4cb6d576d656c542f9 Author: Joakim Bergman <jocke@gipset.se> AuthorDate: 2023-01-08 11:46:12 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-06-26 23:30:29 +0000 security/py-openssl: update to 21.0.0 this is to make devel/py-twisted work (from context of net-p2p/deluge) PR: 264970 Approved by: sbz (maintainer timeout, two weeks) security/py-openssl/Makefile | 2 +- security/py-openssl/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
Thank you for your contribuion.
Also fixed by https://cgit.FreeBSD.org/ports/commit/?id=95f93a2eea17325f25b60138a0b50b6c260cec38.