Bug 265427 - [NEW PORT] graphics/pixelmosh: PNG corrupter
Summary: [NEW PORT] graphics/pixelmosh: PNG corrupter
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/charlesrocket/pixe...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-25 00:34 UTC by -k-
Modified: 2025-05-14 18:29 UTC (History)
1 user (show)

See Also:


Attachments
pixelmosh.patch (14.48 KB, patch)
2022-07-25 00:34 UTC, -k-
no flags Details | Diff
pixelmosh-v1.0.0 (14.44 KB, patch)
2022-07-25 13:38 UTC, -k-
no flags Details | Diff
pixelmosh-v3 + gtk (25.89 KB, patch)
2023-01-18 01:01 UTC, -k-
no flags Details | Diff
pixelmosh-v3 + gtk (25.89 KB, patch)
2023-01-18 01:53 UTC, -k-
no flags Details | Diff
pixelmosh-v3 + gtk (25.97 KB, patch)
2023-01-19 22:51 UTC, -k-
no flags Details | Diff
pixelmosh-v3 + gtk (26.52 KB, patch)
2023-02-01 19:10 UTC, -k-
no flags Details | Diff
pixelmosh-v3 + gtk (26.38 KB, patch)
2023-03-22 19:47 UTC, -k-
no flags Details | Diff
bump to v4.1.0 (29.98 KB, patch)
2025-05-09 04:11 UTC, -k-
no flags Details | Diff
add port v4.1.0 (29.97 KB, patch)
2025-05-09 12:39 UTC, -k-
no flags Details | Diff
add port v4.1.1 (29.92 KB, patch)
2025-05-11 16:38 UTC, -k-
no flags Details | Diff
add port v4.1.2 (30.42 KB, patch)
2025-05-14 18:29 UTC, -k-
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description -k- 2022-07-25 00:34:56 UTC
Created attachment 235461 [details]
pixelmosh.patch
Comment 1 -k- 2022-07-25 13:38:46 UTC
Created attachment 235466 [details]
pixelmosh-v1.0.0
Comment 2 -k- 2023-01-18 01:01:47 UTC
Created attachment 239549 [details]
pixelmosh-v3 + gtk
Comment 3 -k- 2023-01-18 01:50:45 UTC
Oh I need to fix that typo in GUI conditional
Comment 4 -k- 2023-01-18 01:53:12 UTC
Created attachment 239550 [details]
pixelmosh-v3 + gtk
Comment 5 -k- 2023-01-19 22:51:07 UTC
Created attachment 239607 [details]
pixelmosh-v3 + gtk

Added `CONFLICTS_INSTALL`
Comment 6 -k- 2023-02-01 19:10:59 UTC
Created attachment 239844 [details]
pixelmosh-v3 + gtk

Bump to v3.1.0
Comment 7 -k- 2023-03-22 19:47:51 UTC
Created attachment 241056 [details]
pixelmosh-v3 + gtk

Bump to v3.1.1
Comment 8 -k- 2025-05-09 04:11:05 UTC
Created attachment 260276 [details]
bump to v4.1.0
Comment 9 Chris Hutchinson 2025-05-09 08:21:01 UTC
This port looks like it might have some formatting
issues. Have you run

portlint -AC
portfmt -D Makefile
portclippy Makefile

against it?
Comment 10 -k- 2025-05-09 12:13:22 UTC
(In reply to Chris Hutchinson from comment #9)
Yes, both green, including linter with all (-A) flags. But I am going to improve conditional in a few minutes, just in case.
Comment 11 -k- 2025-05-09 12:39:44 UTC
Created attachment 260288 [details]
add port v4.1.0

```
pixelmosh (main) pwd
/home/charlie/src/freebsd-ports/graphics/pixelmosh
pixelmosh (main) portfmt -D -t Makefile
pixelmosh (main) portlint -A
looks fine.
pixelmosh (main)
```

lint, format, and all stages are green
Comment 12 -k- 2025-05-09 12:51:27 UTC
oh, portclippy, I was running linter and formatter. not sure why they pass, but clippy (not in the handbook) outputs some suggestions.
Comment 13 -k- 2025-05-09 13:01:37 UTC
with portclippy and portlint are conflicting with each other, regardless how I shuffle.
Comment 14 -k- 2025-05-09 13:07:25 UTC
apparently clippy has issues with conditionals, so ill ignore it for now
Comment 15 -k- 2025-05-09 13:23:09 UTC
(In reply to Chris Hutchinson from comment #9)
portfmt and portlint (-AC) are green.
clippy has issues with conditional so ill ignore it
Comment 16 Mathieu Arnold freebsd_committer freebsd_triage 2025-05-09 13:32:14 UTC
Also, both portlint and portclippy are static lint tools, they don't understand what you write, they just have a set of rules they think you need to follow.
As a rule though, I'd be more inclined to follow portclippy even if portlint is unhappy with things.
In any way, the committer that takes this will clean things up if needs be.
Comment 17 -k- 2025-05-09 15:09:26 UTC
(In reply to Mathieu Arnold from comment #16)
Got it, thanks. I thought portlint takes precedence over portclippy. I am working on another port with a very similar layout, so maybe I will find a way to satisfy both of them.
Comment 18 -k- 2025-05-11 16:38:16 UTC
Created attachment 260330 [details]
add port v4.1.1
Comment 19 -k- 2025-05-14 18:29:43 UTC
Created attachment 260412 [details]
add port v4.1.2