Created attachment 235461 [details] pixelmosh.patch
Created attachment 235466 [details] pixelmosh-v1.0.0
Created attachment 239549 [details] pixelmosh-v3 + gtk
Oh I need to fix that typo in GUI conditional
Created attachment 239550 [details] pixelmosh-v3 + gtk
Created attachment 239607 [details] pixelmosh-v3 + gtk Added `CONFLICTS_INSTALL`
Created attachment 239844 [details] pixelmosh-v3 + gtk Bump to v3.1.0
Created attachment 241056 [details] pixelmosh-v3 + gtk Bump to v3.1.1
Created attachment 260276 [details] bump to v4.1.0
This port looks like it might have some formatting issues. Have you run portlint -AC portfmt -D Makefile portclippy Makefile against it?
(In reply to Chris Hutchinson from comment #9) Yes, both green, including linter with all (-A) flags. But I am going to improve conditional in a few minutes, just in case.
Created attachment 260288 [details] add port v4.1.0 ``` pixelmosh (main) pwd /home/charlie/src/freebsd-ports/graphics/pixelmosh pixelmosh (main) portfmt -D -t Makefile pixelmosh (main) portlint -A looks fine. pixelmosh (main) ``` lint, format, and all stages are green
oh, portclippy, I was running linter and formatter. not sure why they pass, but clippy (not in the handbook) outputs some suggestions.
with portclippy and portlint are conflicting with each other, regardless how I shuffle.
apparently clippy has issues with conditionals, so ill ignore it for now
(In reply to Chris Hutchinson from comment #9) portfmt and portlint (-AC) are green. clippy has issues with conditional so ill ignore it
Also, both portlint and portclippy are static lint tools, they don't understand what you write, they just have a set of rules they think you need to follow. As a rule though, I'd be more inclined to follow portclippy even if portlint is unhappy with things. In any way, the committer that takes this will clean things up if needs be.
(In reply to Mathieu Arnold from comment #16) Got it, thanks. I thought portlint takes precedence over portclippy. I am working on another port with a very similar layout, so maybe I will find a way to satisfy both of them.
Created attachment 260330 [details] add port v4.1.1
Created attachment 260412 [details] add port v4.1.2