Bug 265454 - sysutils/py-glances: Update to 3.2.7
Summary: sysutils/py-glances: Update to 3.2.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Nuno Teixeira
URL: https://github.com/nicolargo/glances/...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-26 15:53 UTC by Rafael Grether
Modified: 2022-08-12 11:44 UTC (History)
2 users (show)

See Also:
gasol.wu: maintainer-feedback+


Attachments
py-glances-3.2.7.diff (936 bytes, patch)
2022-07-31 00:35 UTC, Nuno Teixeira
no flags Details | Diff
py-glances-3.2.7.diff v2 (2.61 KB, patch)
2022-07-31 16:04 UTC, Nuno Teixeira
no flags Details | Diff
py-glances-3.2.7.diff v3 (2.61 KB, patch)
2022-08-11 13:19 UTC, Nuno Teixeira
gasol.wu: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Grether 2022-07-26 15:53:10 UTC
Hi @MAINTAINER, please update sysutils/py-glances to 3.2.5 version.
There are some bug fixes in new version.
Thanks.
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-31 00:35:53 UTC
Created attachment 235570 [details]
py-glances-3.2.7.diff

recomended:

1. order variables position:
---
# USES block
USES
-USE_PYTHON
USE_GITHUB

-OPTIONS_DEFINE
-OPTIONS_SUB

GH_ACCOUNT
+USE_PYTHON

# Standard bsd.port.mk variables
NO_ARCH

# Packaging list block
PLIST_FILES

# Options definitions
+OPTIONS_DEFINE
+OPTIONS_SUB
---

2. variables alphabetical order:
---
+RUN_DEPENDS=   ${PYTHON_PKGNAMEPREFIX}defusedxml>=0:devel/py-defusedxml@${PY_FLAVOR} \
-RUN_DEPENDS=   ${PYTHON_PKGNAMEPREFIX}psutil>=5.3.0:sysutils/py-psutil@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}future>=0.15.2:devel/py-future@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}packaging>=0:devel/py-packaging@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}psutil>=5.3.0:sysutils/py-psutil@${PY_FLAVOR}
-               ${PYTHON_PKGNAMEPREFIX}defusedxml>=0:devel/py-defusedxml@${PY_FLAVOR} \
-               ${PYTHON_PKGNAMEPREFIX}packaging>=0:devel/py-packaging@${PY_FLAVOR}
---

- unitest: OK
- nice program :)
Comment 2 Gasol Wu 2022-07-31 02:40:01 UTC
lgtm
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-31 16:04:27 UTC
Created attachment 235583 [details]
py-glances-3.2.7.diff v2

While I'm here:

 - switch to DISTVERSION
 - remove unused DOCS option
 - organize variables

Don't know about installing glances.conf{.sample} to ETCDIR as it's already installed in ${PREFIX}/share/doc/glances/glances.conf...
Comment 4 Gasol Wu 2022-08-08 00:14:10 UTC
Got error like this, Details can be found at https://poudriere.gasol.tw/data/130amd64-system/2022-08-08_07h51m59s/logs/errors/py39-glances-3.2.7.log

running install_data
creating /wrkdirs/usr/ports/sysutils/py-glances/work-py39/stage/usr/local/share/doc/glances
copying AUTHORS -> /wrkdirs/usr/ports/sysutils/py-glances/work-py39/stage/usr/local/share/doc/glances
copying COPYING -> /wrkdirs/usr/ports/sysutils/py-glances/work-py39/stage/usr/local/share/doc/glances
copying NEWS.rst -> /wrkdirs/usr/ports/sysutils/py-glances/work-py39/stage/usr/local/share/doc/glances
copying README.rst -> /wrkdirs/usr/ports/sysutils/py-glances/work-py39/stage/usr/local/share/doc/glances
copying CONTRIBUTING.md -> /wrkdirs/usr/ports/sysutils/py-glances/work-py39/stage/usr/local/share/doc/glances
copying conf/glances.conf -> /wrkdirs/usr/ports/sysutils/py-glances/work-py39/stage/usr/local/share/doc/glances
running install_egg_info
Copying Glances.egg-info to /wrkdirs/usr/ports/sysutils/py-glances/work-py39/stage/usr/local/lib/python3.9/site-packages/Glances-3.2.7-py3.9.egg-info
running install_scripts
Installing glances script to /wrkdirs/usr/ports/sysutils/py-glances/work-py39/stage/usr/local/bin
writing list of installed files to '/wrkdirs/usr/ports/sysutils/py-glances/work-py39/.PLIST.pymodtmp'
install  -m 0644 /wrkdirs/usr/ports/sysutils/py-glances/work-py39/glances-3.2.7/conf/glances.conf /wrkdirs/usr/ports/sysutils/py-glances/work-py39/stage/usr/local/etc/py39-glances/glances.conf.sample
install  -m 444 /wrkdirs/usr/ports/sysutils/py-glances/work-py39/glances-3.2.7/docs/man/glances.1 /wrkdirs/usr/ports/sysutils/py-glances/work-py39/stage/usr/local/man/man1/
===> Creating unique files: Move MAN files needing SUFFIX
Makefile error: UNIQUE (suffix): share/man/man1/glances.1 not found
*** Error code 1
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-08-11 13:19:40 UTC
Created attachment 235846 [details]
py-glances-3.2.7.diff v3

fixed PLIST_FILES
Comment 6 Gasol Wu 2022-08-12 03:45:04 UTC
Comment on attachment 235846 [details]
py-glances-3.2.7.diff v3

lgtm
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-08-12 11:42:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=674339c6f42dff111f306715084d660687878e46

commit 674339c6f42dff111f306715084d660687878e46
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2022-08-12 11:31:58 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-08-12 11:31:58 +0000

    sysutils/py-glances: Update to 3.2.7

    ChangeLog:      https://github.com/nicolargo/glances/releases
    PR:             265454
    Reported by:    Rafael Grether <devnull@apt322.org>

 sysutils/py-glances/Makefile | 24 ++++++++++--------------
 sysutils/py-glances/distinfo |  6 +++---
 2 files changed, 13 insertions(+), 17 deletions(-)
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2022-08-12 11:44:10 UTC
Committed, thanks!