Created attachment 235715 [details] Patch for fdk-aac Follow Porters Handbook's USE_GITHUB section and use upstream release archive The files are identical apart from that release archive also packs a configure script pre generated. Compile tested on FreeBSD 13.1-RELEASE
If I am not mistaken it was you who actually switched to GH in bug #252869. Can you clarify like why we should again go back to SF because there again might be cases where we have to get upstream patches when there is no releases?
I think we can consider fdk-aac being more or less "complete" as far as development goes. I will admit that my primary interest was switching to CMake as its usually more beneficial to us in terms of (less) maintenance and overall performance. I simply opted for GitHub as backporting and cherry picking would've been a lot more work. Best regards, Daniel
Thanks for the clarification. Currently I don't see a super urgent requirement to switch the MASTER_SITES as often the src distrib and actual distrib differs; not up for a POLA. So I will keep this open and commit on next upgrade.
I was indirect reminded of this due to https://reviews.freebsd.org/D36039 (mainly because of sharing dist files) Source files are the same or at least diff can't tell any differences on my box.
(In reply to Daniel Engberg from comment #4) Oops. Okiz. Give me a day or two. Today is already late for my builder. As it's still crying for more CPU power. :'(
Friendly ping
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=68c48e58781586881987d5efed0f9b8d804eccbc commit 68c48e58781586881987d5efed0f9b8d804eccbc Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-08-19 17:25:46 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2022-08-19 17:27:18 +0000 audio/fdk-aac: Use upstream release archive Follow Porters Handbook's USE_GITHUB section and use upstream release archive The files are identical apart from that release archive also packs a configure script pre generated. PR: 265670 Reported by: diizzy audio/fdk-aac/Makefile | 5 +---- audio/fdk-aac/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 7 deletions(-)