Created attachment 236149 [details] Check for WWW in Makefile, reject it in pkg-descr There have been multople requests to move the project URL from the last line of the pkg-descr file into the Makefile (see review D2949 and review D34979, and the proposed documentation change review D36369). In coordination with PortMgr I'm currently working on this change, and one of the pre-requisites is that portlint is adapted to this change. Please see the attached patch. This patch should not be committed before all the other preparations have been completed (e.g. documentation changes) and the sweeping update of all ports can be committed. Please let me know which time constraints there are with regard to an update of the portlint port, to allow it to be committed in close sequence to the update of the port Makefiles and pkg-descr files. If you approve this patch, I could commit it together with the move of WWW to the port Makefiles - this might reduce the time window where portlint does not match the new convention of WWW= in the Makefile.
Hey, Stefan. I have two changes in my private git repo ready to go. I can add this as well and commit when you're ready.
(In reply to Joe Marcus Clarke from comment #1) Hi Joe, I'm technically ready to go - portlint has been the biggest issue since it would flag the new style (WWW in Makefile instead of pkg-descr file) as error. I do fully agree that the time window between the portlint update and the implementation of the planned change of all Makefiles should be as short as possible. The patch provided with this PR does flag deviations from the new configuration as warnings, not as error, for this reason. (A later change to an error might be appropriate for some of the tests.) I'll discuss this conversion with members of the PortMgr team later today and I'd appreciate if you'd update portlint at an agreed upon time within the next 48 hours. The best time of day (low commit frequency) for the large commit to >30000 each Makefiles and pkg-descr files seems to be between 2300 and 0700 UTC (corresponding to late afternoon to night in the US?). But feel free to suggest any time that is appropriate for you for the portlint commit - I'll then try to push the commit to the ports tree with as little delay as possible. Thank you for your support!
I'm good to go when you are. You just tell me when to pull the trigger.
(In reply to Joe Marcus Clarke from comment #3) Please just commit the portlint update at any time within the next 16 hours, if possible (between now and 2022-09-07 2200 UTC). And please notify me by mail to se@freebsd.org about that commit - either after pushing it or (preferred) some time in advance.
This has been done.