Bug 266350 - audio/libmad: Fix distinfo and only enable ASO on supported 32-bit platforms
Summary: audio/libmad: Fix distinfo and only enable ASO on supported 32-bit platforms
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-11 00:18 UTC by Daniel Engberg
Modified: 2022-10-05 02:00 UTC (History)
0 users

See Also:

Attachments
Patch for libmad (1.02 KB, patch)
2022-09-11 00:18 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-09-11 00:18:05 UTC 
Created attachment 236488 [details]
Patch for libmad

distinfo contains stale info for obsolete patch file and only enable ASO on armv6/v7/i386
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-09-27 10:31:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b54d35f00b6227425ff19ca78c321ab80e99b8cc

commit b54d35f00b6227425ff19ca78c321ab80e99b8cc
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-09-27 09:53:54 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-09-27 10:30:37 +0000

    audio/libmad: Fix distinfo and only enable ASO on supported 32-bit platforms

    Distinfo contains stale info for obsolete patch file andonly enable ASO
    on armv6/v7/i386

    PR:             266350
    Approved by:    portmgr (maintainer timeout, 2+ weeks)

 audio/libmad/Makefile | 6 +++++-
 audio/libmad/distinfo | 4 +---
 2 files changed, 6 insertions(+), 4 deletions(-)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-10-01 05:15:01 UTC 
Thanks for cleaning up the distinfo.

BTW, I don't see any reason for limiting ASO to  32-bit architecture. Could you please provide further information. Thanks.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-10-01 20:26:09 UTC 
Hi,

ASO is only available on 32-bit according to https://github.com/tenacityteam/libmad/blob/main/CMakeLists.txt#L54

Best regards,
Daniel
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-10-03 08:27:37 UTC 
(In reply to Daniel Engberg from comment #3)

Ah, you're correct. I misunderstood the logic of the following lines (55 to 87) when I added ASO option. Thanks.
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-10-05 02:00:40 UTC 
(In reply to Daniel Engberg from comment #3)

I just recalled that why I enabled ASO unconditionally. It is enabled by default in CMakeLists.txt. It just has no effect on unsupported architectures. Therefore, it is OK to set CMAKE_ON=ASO unconditionally.