Created attachment 236595 [details] Git-formatted patch Port maintainer here. Current version does not support PHP 8. This is a crucial patch for the next quarterly branch. Tested in Poudriere with 7.4, 8.0, 8.1. Attached is a Git-formatted patch with a sane commit message.
Thank you Neel, but I cannot find the commit on main. Did you push?
Reopening since commit hasn't happen yet.
Friendly reminder. This has to land in the next quartely branch.
Take.
(In reply to Yasuhiro Kimura from comment #4) Thank you, looking forward to.
Hi Michael, I checked both http://pear.geshi.org/ and http://pear.geshi.org/feed.xml but can't fild 1.0.9.1 in either of them. Is 1.0.9.1 really released? Aren't you trying to apply some patches to 1.0.9.0?
(In reply to Yasuhiro Kimura from comment #6) > Aren't you trying to apply some patches to 1.0.9.0? If so, you should bump PORTREVISION rather than PORTVERSION.
(In reply to Yasuhiro Kimura from comment #6) Let me explain: The PEAR channel does NOT contain this version. I have no idea who to contact about this. The Git repo does contain 1.0.9.1 (https://github.com/GeSHi/geshi-1.0/releases/tag/v1.0.9.1). I have manually created the patch which brings the port upto the new version for PHP 8. Bumping the port revision would be wrong since I don't apply any FreeBSD specific patches, but really bump the actual version.
(In reply to Michael Osipov from comment #8) I checked upstream repository and found archive file of 1.0.9.1 is provided as https://github.com/GeSHi/geshi-1.0/releases/download/v1.0.9.1/GeSHi-1.0.9.1.tar.gz. So it seems better to update MASTER_SITES to 'https://github.com/GeSHi/geshi-1.0/releases/download/v${PORTVERSION}/' and get archive file of 1.0.9.1 from there.
(In reply to Yasuhiro Kimura from comment #9) Technically, yes, but this is already covered by devel/php-geshi. This is the PEAR version of the project which is automatically added to the include_path in PHP. Applying your proposal would turn this port into a dup of devel/php-geshi which doesn't make sense. The upstream port devel/websvn relies on the PEAR version of this port.
Note that pear(1) is invoked to install, no munual installation happens here.
(In reply to Michael Osipov from comment #10) I got it. Thanks for explanation.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=73e6b03413c952554b336f27f00d268dc88b9fc2 commit 73e6b03413c952554b336f27f00d268dc88b9fc2 Author: Michael Osipov <michael.osipov@siemens.com> AuthorDate: 2022-09-30 10:43:13 +0000 Commit: Yasuhiro Kimura <yasu@FreeBSD.org> CommitDate: 2022-09-30 10:54:49 +0000 devel/pear-geshi: Update to 1.0.9.1 PR: 266448 devel/pear-geshi/Makefile | 3 +- devel/pear-geshi/files/patch-package.xml (new) | 566 +++ .../files/patch-v1.0.9.0...v1.0.9.1 (new) | 3723 ++++++++++++++++++++ 3 files changed, 4291 insertions(+), 1 deletion(-)
Committed. Thanks!
(In reply to Yasuhiro Kimura from comment #14) Thank you, your immediate help is appreciated.