Bug 266473 - cgit.freebsd.org breaks some links – seems to not recognise some types of URI delimiter (RFC 3986)
Summary: cgit.freebsd.org breaks some links – seems to not recognise some types of URI...
Status: Open
Alias: None
Product: Services
Classification: Unclassified
Component: Git Integration (show other bugs)
Version: unspecified
Hardware: Any Any
: --- Affects Some People
Assignee: Git Admin
URL: https://datatracker.ietf.org/doc/html...
Depends on:
Reported: 2022-09-17 22:13 UTC by Graham Perrin
Modified: 2023-02-11 10:32 UTC (History)
1 user (show)

See Also:

Screenshot: broken link (129.17 KB, image/png)
2022-09-23 04:43 UTC, Graham Perrin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer 2022-09-17 22:13:56 UTC
Bugged pages include: 

* <https://cgit.freebsd.org/doc/commit/?id=f814150c1af932259a239ad01c0237f58bdce402>
* <https://cgit.freebsd.org/doc/commit/?id=9d5951404e425725a84265113abef1c3b2e86d91>

From <https://lists.zx2c4.com/pipermail/cgit/2022-September/004755.html>: 

> Commit message formatting in CGit is extensible and the example filter
> shipped with CGit does not do any URL detection, so cgit.freebsd.org
> must be using their own filter.
> I suggest you report a bug to them.

Please, is a fix possible? 

Comment 1 Graham Perrin freebsd_committer 2022-09-23 04:43:08 UTC
Created attachment 236759 [details]
Screenshot: broken link

Also misrepresented: the link in the comment at today's <https://cgit.freebsd.org/doc/commit/?id=e52d783241b887cfd1e9760d34ab9657dfac4d6c>. 

This commit used white space to delimit.
Comment 2 Graham Perrin freebsd_committer 2022-09-23 05:39:58 UTC
From <https://reviews.freebsd.org/D35603#810251>: 

> … Because of the <> around the URL confuse the phabricator commit 
> message parser so this differential is not marked as merged automatically.

I can't guess the plumbing between things such as cgit.freebsd.org and reviews.freebsd.org but for what it's worth, Phabricator representations of commits seem to be _not_ bugged. Example pairs: 



Comment 3 Graham Perrin freebsd_committer 2023-02-11 10:32:40 UTC
Another example: <https://cgit.freebsd.org/src/commit/?id=c2f16c595eb51c6e0cb6ece3f6f078d738019059>