Bug 266666 - why does /etc/mtree/BSD.usr.dist make /usr/share/zoneinfo/SystemV, and OBSOLETEFILES deletes it?
Summary: why does /etc/mtree/BSD.usr.dist make /usr/share/zoneinfo/SystemV, and OBSOLE...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords:
: 266667 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-09-28 00:38 UTC by Larry Rosenman
Modified: 2022-10-02 00:34 UTC (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Larry Rosenman freebsd_committer freebsd_triage 2022-09-28 00:38:50 UTC 
902             SystemV
    903             ..
    904             US
    905             ..
    906         ..
    907     ..
    908     src             nochange
    909     ..
    910 ..
/etc/mtree/BSD.usr.dist: unmodified, readonly: line 902 of 910 [99%]

  16423 OLD_DIRS+=usr/share/zoneinfo/SystemV
  16424 OLD_FILES+=usr/share/doc/ntp/accopt.htm
  16425 OLD_FILES+=usr/share/doc/ntp/assoc.htm
  16426 OLD_FILES+=usr/share/doc/ntp/audio.htm
/usr/src/ObsoleteFiles.inc: unmodified, readonly: line 16423 of 16817 [97%]

this seems like someone overlooked something.
Comment 1 Larry Rosenman freebsd_committer freebsd_triage 2022-09-28 00:43:21 UTC 
*** Bug 266667 has been marked as a duplicate of this bug. ***
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-09-29 15:45:16 UTC 
Hi,

Maybe related to:
---
commit da038df8c92b71060965bdc5dc400db54de35587
Author: Philip Paeps <philip@FreeBSD.org>
Date:   Sun Sep 25 13:42:18 2022 +0800

    share/zoneinfo: don't build obsolete SystemV zones

    The /usr/share/zoneinfo/SystemV directory has been empty on FreeBSD
    since 2006.  The upstream source file was removed in 2020.  Also stop
    passing yearisdate to zic(8).  This has not been necessary for years.
    The script has been removed upstream since 2020.
---

Cheers
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-09-29 16:02:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=b4d15fdd53d7a30ea7ce7e6903ed547f00200719

commit b4d15fdd53d7a30ea7ce7e6903ed547f00200719
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2022-09-29 15:56:25 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-09-29 16:01:34 +0000

    Remove obsolete SystemV dir from BSD.usr.dist

    /usr/share/zoneinfo/SystemV is removed via ObsoleteFiles as of commits
    da038df8c92b and 57338837aef5, so do not create it in the first place.

    PR:             266666
    Fixes:          da038df8c92b ("share/zoneinfo: don't build obsolete...")
    MFC after:      3 days

 etc/mtree/BSD.usr.dist | 2 --
 1 file changed, 2 deletions(-)
Comment 4 Philip Paeps freebsd_committer freebsd_triage 2022-09-30 01:13:52 UTC 
Good catch.  I overlooked this one.  Thanks Ed, for fixing this in main.  I'll include it in the errata notice I'm typing this morning.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-10-02 00:33:08 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=64e900d8867c7f46c97028873d437952a4b22be4

commit 64e900d8867c7f46c97028873d437952a4b22be4
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2022-09-29 15:56:25 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-10-02 00:32:45 +0000

    Remove obsolete SystemV dir from BSD.usr.dist

    /usr/share/zoneinfo/SystemV is removed via ObsoleteFiles as of commits
    da038df8c92b and 57338837aef5, so do not create it in the first place.

    PR:             266666
    Fixes:          da038df8c92b ("share/zoneinfo: don't build obsolete...")
    MFC after:      3 days

    (cherry picked from commit b4d15fdd53d7a30ea7ce7e6903ed547f00200719)

 etc/mtree/BSD.usr.dist | 2 --
 1 file changed, 2 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-10-02 00:34:09 UTC 
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=00d2b8d5d8afa6bc45ab0885d083d6f9da2e6024

commit 00d2b8d5d8afa6bc45ab0885d083d6f9da2e6024
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2022-09-29 15:56:25 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-10-02 00:33:11 +0000

    Remove obsolete SystemV dir from BSD.usr.dist

    /usr/share/zoneinfo/SystemV is removed via ObsoleteFiles as of commits
    da038df8c92b and 57338837aef5, so do not create it in the first place.

    PR:             266666
    Fixes:          da038df8c92b ("share/zoneinfo: don't build obsolete...")
    MFC after:      3 days

    (cherry picked from commit b4d15fdd53d7a30ea7ce7e6903ed547f00200719)

 etc/mtree/BSD.usr.dist | 2 --
 1 file changed, 2 deletions(-)