Created attachment 237073 [details] Patch Trying to build archivers/py-borgbackup when having BORG_NEW_PASSPHRASE defined in environnement will fails because of smoke tests with last borg version (1.2.2). See in attachment my suggested patch.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3be035569652b94df37bc87306c0d9ab970069bc commit 3be035569652b94df37bc87306c0d9ab970069bc Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2022-10-04 20:22:08 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2022-10-04 20:24:08 +0000 archivers/py-borgbackup: clean environment for self-tests This avoids build failures when, for instance, BORG_NEW_PASSWORD is set to another password than the one used by the self-tests. Reported by: SimpleRezo <simplerezo@gmail.com> PR: 266821 Not bumping PORTREVISION because this only affects the execution of self-tests, which is pass (then the change is irrelevant) or fail (then there is no package or installed port and PORTREVISION would serve no purpose). archivers/py-borgbackup/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Hi Rezo, thanks for your report and the suggested patch, which did work for me in testing. I have chosen a different approach, however, and am pruning the environment (through: env -i) for the self-tests altogether, who knows what variable will come with some future borgbackup when we have forgotten about this... that seems more maintainable to me.
Much better indeed to use env -i, thanks for your reactivity :)