Bug 266837 - devel/xc3sprog: Adopt/Update to latest commit
Summary: devel/xc3sprog: Adopt/Update to latest commit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/DanielO/xc3sprog
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-05 07:28 UTC by Daniel O'Connor
Modified: 2022-10-07 11:29 UTC (History)
1 user (show)

See Also:


Attachments
Update the port (3.56 KB, patch)
2022-10-05 07:28 UTC, Daniel O'Connor
no flags Details | Diff
git diff version with WWW fix (3.46 KB, patch)
2022-10-05 12:43 UTC, Daniel O'Connor
no flags Details | Diff
xc3sprog-g20221005,1 v1 (3.76 KB, patch)
2022-10-05 14:41 UTC, Nuno Teixeira
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel O'Connor 2022-10-05 07:28:24 UTC
Created attachment 237092 [details]
Update the port

We use xc3sprog at work and I have forked it and made various modifications to add functionality and merged in other PRs. I have also incorporated all of the patches required for FreeBSD building and fixed numerous warnings.

I added port epoch because r769 > g20221005.
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-05 12:23:09 UTC
Hello Daniel,

1.
Are you sure that project is not active?
Latest activity was in 2018-03-30...

2.
pkg-descr WWW url is deprecated. Please make sure that you fetch current ports and send a git diff.
Comment 2 Daniel O'Connor 2022-10-05 12:43:31 UTC
Created attachment 237097 [details]
git diff version with WWW fix
Comment 3 Daniel O'Connor 2022-10-05 12:44:07 UTC
I haven't seen any activity on PRs or issues for years on the upstream GH project so I think it is dead.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-05 14:41:09 UTC
Created attachment 237104 [details]
xc3sprog-g20221005,1 v1

- Makefile cleanup
- Use PORTVERSION since it contains letter
- Install missing binaries [1]
- Install manual page [1]
- Use pkg-plist (>5 items)

[1] check pkg-plist
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-05 14:41:58 UTC
(In reply to Nuno Teixeira from comment #4)
(...)

- Add LICENSE
Comment 6 Daniel O'Connor 2022-10-07 04:32:44 UTC
Comment on attachment 237104 [details]
xc3sprog-g20221005,1 v1

Thanks Nuno, that patch looks better.
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-07 10:28:53 UTC
Just one more important point: we are bumping PORTEPOCH since r769 > g20221005,
and my question is: will be released versions on forked upstream?

I'm asking this because we could avoid bumping epoch.

All set to commit.
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-07 10:30:26 UTC
(In reply to Nuno Teixeira from comment #7)
(...)

And port run depends on misc/fxload that is unmaintained and WWW url is not working. Could you check if project moved to https://github.com/esden/fxload ?

Thanks
Comment 9 Daniel O'Connor 2022-10-07 10:45:57 UTC
The previous release was based on SVN but it is only a revision number not a tag or branch.

It was then translated to git but of course the revision number no longer exists so it had to change.

Since I am now the upstream I guess I could do a release but I was hoping to not have to as I think the project is basically mature and in stasis now except for minor patches.

fxload is similar - it is unlikely to change significantly in the future.

I think the URL you have suggested is a reasonable one to use (and IMO they are a good steward FWIW).
Comment 10 commit-hook freebsd_committer freebsd_triage 2022-10-07 11:28:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0b60f7adf078de7923223cef6c2e4493bae966cd

commit 0b60f7adf078de7923223cef6c2e4493bae966cd
Author:     Daniel O'Connor <darius@dons.net.au>
AuthorDate: 2022-10-07 11:24:12 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-07 11:27:30 +0000

    devel/xc3sprog: Adopt/Update to latest commit

     - Move to forked project [1]
     - Makefile cleanup
     - Install missing binaries
     - Install manual page
     - Use pkg-plist (>5 items)
     - Add LICENSE
     - Submitter becomes maintainer
     - Bump PORTEPOCH

    [1] Original project have no activity for years

    WWW: https://github.com/DanielO/xc3sprog

    PR:             266837

 devel/xc3sprog/Makefile                          | 27 +++++++++++++-----------
 devel/xc3sprog/distinfo                          |  5 +++--
 devel/xc3sprog/files/patch-CMakeLists.txt (gone) | 11 ----------
 devel/xc3sprog/files/patch-utilities.cpp (gone)  | 10 ---------
 devel/xc3sprog/pkg-descr                         |  4 ++--
 devel/xc3sprog/pkg-message (gone)                | 11 ----------
 devel/xc3sprog/pkg-plist (new)                   |  8 +++++++
 7 files changed, 28 insertions(+), 48 deletions(-)
Comment 11 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-07 11:29:54 UTC
Committed, thanks!