Bug 267042 - devel/qt6-translations: not being properly registered as a dependency
Summary: devel/qt6-translations: not being properly registered as a dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-14 10:23 UTC by Guido Falsi
Modified: 2022-10-14 14:51 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+

Attachments
patch v1 (572 bytes, patch)
2022-10-14 10:23 UTC, Guido Falsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2022-10-14 10:23:45 UTC 
Created attachment 237291 [details]
patch v1

Hi,

First of all thanks for the hard work done on porting qt6!

Unluckily I've noticed a small glitch. A port having devel/qt6-translations will not get it properly registered as a dependency in the package, causing poudriere to constantly rebuilding the port due to a new dependency.

This shows up with this message in the poudriere log:

===>  Building package for py39-qt6-pyqt-6.4.0
actual-package-depends: dependency on /usr/local/share/qt6/translations not registered (normal if it belongs to base)
pkg-static: DEBUG: -/


(note, the log mentions the py-qt6 port I'm working on, but patches are still not ready for publication though)


I have discovered this happens due to the dependency for devel/qt6-translations referencing a directory and not an actual file, something pkg does not act well on.

So I'm attaching a patch changing Mk/Uses/qt.mk to reference a random file from the ones installed by the port. This fixes this issue.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2022-10-14 11:12:40 UTC 
lgtm
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-14 12:23:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ceba7a5169d05f28576c30003c70a506b81d1a08

commit ceba7a5169d05f28576c30003c70a506b81d1a08
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2022-10-14 12:19:33 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2022-10-14 12:20:57 +0000

    devel/qt6-translations: Make dependency point to an actual installed file

    Pointing to a directory causes issues with pkg.

    PR:             267042
    Approved by:    kde (tcberner)

 Mk/Uses/qt.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2022-10-14 12:25:00 UTC 
Patch committed.

Thanks for the fast feedback!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-10-14 14:51:12 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3b0f5a8519111dd5b6ca0d23d7241f5e4ae7cd5e

commit 3b0f5a8519111dd5b6ca0d23d7241f5e4ae7cd5e
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2022-10-14 12:19:33 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2022-10-14 14:50:23 +0000

    devel/qt6-translations: Make dependency point to an actual installed file

    Pointing to a directory causes issues with pkg.

    PR:             267042
    Approved by:    kde (tcberner)

    (cherry picked from commit ceba7a5169d05f28576c30003c70a506b81d1a08)

 Mk/Uses/qt.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)