Bug 267070 - math/eigen3: Use USE_GITLAB
Summary: math/eigen3: Use USE_GITLAB
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-15 09:05 UTC by Daniel Engberg
Modified: 2022-10-22 20:12 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+


Attachments
Patch for eigen3 (1.34 KB, patch)
2022-10-15 09:05 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-10-15 09:05:01 UTC
Created attachment 237322 [details]
Patch for eigen3

Use USE_GITLAB to follow Porters Handbook more closely and be consistent with ports tree

Compile tested on FreeBSD 13.1-STABLE (amd64)
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2022-10-22 10:40:06 UTC
Moin moin 

I'm not quite sure this is that important -- it requires people to refetch the distfile for nothing to gain (from a user standpoint).

The idea is good to make the port match the porters handbook, but I think it would be probably better done in a port-update, or a framework wide change.

However, I don't feel strong about it :-) -- So if you can verify that the distfile has identical content, feel free to ship it.


mfg Tobias
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-22 20:10:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9e2b88e5e05756597ec001d61dc1bb47e552d0b1

commit 9e2b88e5e05756597ec001d61dc1bb47e552d0b1
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-10-22 20:07:52 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-10-22 20:10:30 +0000

    math/eigen3: Use USE_GITLAB

    Use USE_GITLAB to follow Porters Handbook more closely and be consistent
    with ports tree

    PR:             267070
    Approved by:    kde (tcberner)

 math/eigen3/Makefile | 6 ++++--
 math/eigen3/distinfo | 6 +++---
 2 files changed, 7 insertions(+), 5 deletions(-)