Bug 267667 - archivers/liblz4: include updated meson tests
Summary: archivers/liblz4: include updated meson tests
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-09 11:36 UTC by Martin Waschbüsch
Modified: 2024-08-24 03:13 UTC (History)
1 user (show)

See Also:

Attachments
patch to include updated meson tests (63.66 KB, patch)
2022-11-09 11:36 UTC, Martin Waschbüsch 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Waschbüsch 2022-11-09 11:36:05 UTC 
Created attachment 237976 [details]
patch to include updated meson tests

Cherry-picked https://github.com/lz4/lz4/commit/214bfb325bd4db112b73859912b919aa35e12d61
Comment 1 Martin Waschbüsch 2022-11-09 11:41:22 UTC 
Tests now build and mostly work. One of the tests fails on my system:

===>  Testing for liblz4-1.9.4_1,1
[  0% 1/1] /usr/local/bin/meson test --no-rebuild --print-errorlogs
 1/17 checkFrame                             OK               0.05s
 2/17 decompress-partial-usingDict.c         OK               0.04s
 3/17 decompress-partial.c                   OK               0.04s
 4/17 freestanding                           FAIL             0.03s   killed by signal 10 SIGBUS
>>> MALLOC_PERTURB_=70 /srv/poudriere/ports/default/archivers/liblz4/work/lz4-1.9.4/contrib/meson/_build/meson/tests/freestanding

 5/17 datagen                                OK               0.08s
 6/17 lz4-frame-concatenation                OK               0.03s
 7/17 lz4-skippable                          OK               0.02s
 8/17 lz4-multiple                           OK               0.05s
 9/17 lz4-multiple-legacy                    OK               0.07s
10/17 lz4-sparse                             OK               0.17s
11/17 lz4-contentSize                        OK               0.40s
12/17 lz4-testmode                           OK               0.42s
13/17 lz4-dict                               OK               1.16s
14/17 lz4-basic                              OK               1.33s
15/17 lz4-opt-parser                         OK               2.30s
16/17 lz4-fast-hugefile                      OK              28.32s
17/17 lz4hc-hugefile                         OK              73.86s
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-11-09 13:04:56 UTC 
Hi,

You're on 13.1-RELEASE?

Best regards,
Daniel
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-11-09 13:06:21 UTC 
Hit save too fast, amd64 or any other arch?

I can reproduce this on 13.1-STABLE on amd64 using both (g)make build system and meson. I also tried GCC and Clang, both fail.
Comment 4 Martin Waschbüsch 2022-11-09 13:08:10 UTC 
(In reply to Daniel Engberg from comment #3)

I am on amd64 running:

# freebsd-version 
13.1-RELEASE-p3

:-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-11-09 13:23:01 UTC 
Thanks, I've submitted a PR upstream about it.
https://github.com/lz4/lz4/issues/1186
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2023-12-29 05:14:25 UTC 
Comment on attachment 237976 [details]
patch to include updated meson tests

^Triage: convert this to text/plain and set the Patch flag so that the
automation can see it.
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2024-08-24 03:13:11 UTC 
Fixed as of 8f903269750cee05f8286f476944125358abfd5e