Bug 267834 - multimedia/obs-studio: Update luajit to luajit-devel
Summary: multimedia/obs-studio: Update luajit to luajit-devel
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords: needs-qa
: 269091 (view as bug list)
Depends on:
Blocks: 267656
  Show dependency tree / graph
 
Reported: 2022-11-17 20:44 UTC by Tomasz "CeDeROM" CEDRO
Modified: 2023-02-03 13:26 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
luajit -> luajit-devel + portrevision bump. (1.15 KB, patch)
2022-11-17 20:44 UTC, Tomasz "CeDeROM" CEDRO 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz "CeDeROM" CEDRO 2022-11-17 20:44:39 UTC 
Created attachment 238148 [details]
luajit -> luajit-devel + portrevision bump.

Hello world :-)

As noted in [1] the dependency package luajit's upstream will not provide releases (last was in 2017) and they enforce people to use git repo for the source code. Because of that most packages will use now luajit-devel as the most up to date dependency. 

Attached patch updates dependency of luajit to luajit-devel + portrevision bump.

Please verify :-)
Tomek
Comment 1 Tomasz "CeDeROM" CEDRO 2022-11-17 20:45:23 UTC 
[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267656
Comment 2 Tomasz "CeDeROM" CEDRO 2022-11-17 20:56:26 UTC 
Ah, I missed the fix has been already provided in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267656. Closing :-)
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2022-11-29 23:01:54 UTC 
Changes as proposed here, have not been committed (re-open accordingly).

If this issue is resolved via another issue, dependency can be set accordingly. Will leave bug 267656 in See Also if/until that occurs.
Comment 4 Tomasz "CeDeROM" CEDRO 2022-11-29 23:33:32 UTC 
Thank you @koobs :-) 

Please note that I have closed this Issue as there is a better patch (using USES=luajit) provided by @yuri here https://bz-attachments.freebsd.org/attachment.cgi?id=237970 in the Issue report here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267656.
Comment 5 Tomasz "CeDeROM" CEDRO 2022-11-29 23:35:19 UTC 
Comment on attachment 238148 [details]
luajit -> luajit-devel + portrevision bump.

The valid patch as provided by yuri@ is provided here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267656.

diff --git a/multimedia/obs-studio/Makefile b/multimedia/obs-studio/Makefile
index 6c3d59ba47ac..58c8c439ec19 100644
--- a/multimedia/obs-studio/Makefile
+++ b/multimedia/obs-studio/Makefile
@@ -1,6 +1,6 @@
 PORTNAME=	obs-studio
 DISTVERSION=	27.2.4
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	multimedia
 
 PATCH_SITES=	https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/commit/
@@ -43,14 +43,8 @@ LIB_DEPENDS=	libavcodec.so:multimedia/ffmpeg \
 		libxcb-util.so:x11/xcb-util \
 		libxkbcommon.so:x11/libxkbcommon \
 		${LIB_DEPENDS_${ARCH}}
-LIB_DEPENDS_amd64=	libluajit-5.1.so:lang/luajit
-LIB_DEPENDS_armv7=	libluajit-5.1.so:lang/luajit
-LIB_DEPENDS_i386=	libluajit-5.1.so:lang/luajit
-LIB_DEPENDS_powerpc=	libluajit-5.1.so:lang/luajit
-LIB_DEPENDS_powerpc64=	libluajit-5.1.so:lang/luajit-openresty
-LIB_DEPENDS_powerpc64le=	libluajit-5.1.so:lang/luajit-openresty
-
-USES=		cmake compiler:c++17-lang gl gnome lua pkgconfig python:3.4+ \
+
+USES=		cmake compiler:c++17-lang gl gnome lua luajit pkgconfig python:3.4+ \
 		qt:5 xorg
 USE_QT=		core gui network svg widgets x11extras xml buildtools:build imageformats:run qmake:build
 USE_GNOME=	glib20
Comment 6 Jan Beich freebsd_committer freebsd_triage 2023-01-25 19:17:17 UTC 
*** Bug 269091 has been marked as a duplicate of this bug. ***