Bug 267907 - net-mgmt/promscale: Add an option to configure the promscale command line arguments
Summary: net-mgmt/promscale: Add an option to configure the promscale command line ar...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-21 21:37 UTC by Jony Hudson
Modified: 2022-12-03 18:39 UTC (History)
2 users (show)

See Also:
fernape: maintainer-feedback? (feld)

Attachments
Patch to add command line configuration option (1.70 KB, patch)
2022-11-21 21:37 UTC, Jony Hudson 		no flags Details | Diff
Patch to add command line configuration option (1.70 KB, patch)
2022-11-21 23:49 UTC, Jony Hudson 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jony Hudson 2022-11-21 21:37:06 UTC 
Created attachment 238232 [details]
Patch to add command line configuration option

The attached patch adds an option to pass command line arguments to the promscale process, to handle non-default configurations.

The patch also has a couple of other minor changes - fixing a typo, and adding a syslog tag - that I'm happy to split into separate patches, or remove, if you prefer.
Comment 1 Jony Hudson 2022-11-21 21:41:35 UTC 
CC'ing feld@FreeBSD.org by hand as I mis-spelled the port name when filing the bug, thereby breaking the auto-assignment :-)
Comment 2 Jony Hudson 2022-11-21 23:49:21 UTC 
Created attachment 238238 [details]
Patch to add command line configuration option

Missing $ in the last patch.
Comment 3 Mark Felder freebsd_committer freebsd_triage 2022-12-03 18:39:21 UTC 
Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-12-03 18:39:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=90586c77f6c11915db367c7890e30a1c24b5a7f8

commit 90586c77f6c11915db367c7890e30a1c24b5a7f8
Author:     Mark Felder <feld@FreeBSD.org>
AuthorDate: 2022-12-03 18:37:14 +0000
Commit:     Mark Felder <feld@FreeBSD.org>
CommitDate: 2022-12-03 18:38:58 +0000

    net-mgmt/promscale: rc script improvements

    PR:     267907

 net-mgmt/promscale/Makefile           |  1 +
 net-mgmt/promscale/files/promscale.in | 11 +++++++----
 2 files changed, 8 insertions(+), 4 deletions(-)