Created attachment 238450 [details] Upgrade fmtlib to 9.1.0 - All test pass; - devel/spdlog and several other dependencies are OK. PORTREVISION must be bumped for dependent ports.
Why switch from the release archive (this also goes against Porters Handbook USE_GITHUB section)?
Created attachment 238514 [details] Patch for libfmt Use release archive Convert do-test section to cmake:testing
Comment on attachment 238514 [details] Patch for libfmt Isn’t it better to set USE_GITHUB=yes and GH_ACCOUNT=fmtlib ?
USE_GITHUB will utilize codeload.github.com ( https://cgit.freebsd.org/ports/tree/Mk/bsd.sites.mk#n304 ) which generates archives on the fly that can change over time and as previously mentioned also goes against what Porters Handbook recommends. USE_GITHUB should be considered last resort even if the project is hosted on GitHub. Another reason why you might want to use it is if unit tests aren't included in release archive, if we utilize those that is.
(In reply to Daniel Engberg from comment #4) I did not know that: this is not sufficient to update the Porters Handbook, we do not read it everyday: /usr/ports/CHANGES should be notified. And yet better, it would be great to modify Mk/bsd.sites.mk so that USE_GITHUB fetches the right files!
(In reply to Thierry Thomas from comment #5) I think Porters Handbook is pretty clear on the subject? "If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file" https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github
Any news on this?
Committed, after maintainer’s time-out.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=697dec8ed250266e33f8e1bb07bccfbb7035453e commit 697dec8ed250266e33f8e1bb07bccfbb7035453e Author: Thierry Thomas <thierry@FreeBSD.org> AuthorDate: 2022-12-19 09:22:13 +0000 Commit: Thierry Thomas <thierry@FreeBSD.org> CommitDate: 2022-12-19 09:31:33 +0000 devel/libfmt: upgrade to 9.1.0 Previous patch modified to remove USE_GITHUB and switch to cmake:testing. PR: 268081 Reported by: diizzy Approved by: maintainer’s time-out devel/libfmt/Makefile | 16 +++++----------- devel/libfmt/distinfo | 6 +++--- 2 files changed, 8 insertions(+), 14 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2af489c04c7079c98287d0aa27e62fc008e0493e commit 2af489c04c7079c98287d0aa27e62fc008e0493e Author: Thierry Thomas <thierry@FreeBSD.org> AuthorDate: 2022-12-19 09:30:06 +0000 Commit: Thierry Thomas <thierry@FreeBSD.org> CommitDate: 2022-12-19 09:31:34 +0000 */*: chase the upgrade of devel/libfmt to 9.1.0 PR: 268081 audio/furnace/Makefile | 2 +- audio/musicpd/Makefile | 2 +- audio/rsgain/Makefile | 1 + audio/sdl_audiolib/Makefile | 2 +- cad/openroad/Makefile | 2 +- chinese/fcitx5-chinese-addons/Makefile | 2 +- databases/tiledb/Makefile | 1 + devel/bear/Makefile | 2 +- devel/fbthrift/Makefile | 1 + devel/fccf/Makefile | 1 + devel/folly/Makefile | 1 + devel/malloy/Makefile | 1 + devel/opendht/Makefile | 1 + devel/spdlog/Makefile | 1 + editors/turbo/Makefile | 1 + emulators/dolphin-emu/Makefile | 2 +- emulators/pcsx2/Makefile | 1 + games/0ad/Makefile | 2 +- games/devilutionX/Makefile | 1 + games/easyrpg-player/Makefile | 2 +- graphics/openimageio-ociov1/Makefile | 2 +- graphics/openimageio/Makefile | 2 +- graphics/py-openimageio/Makefile | 2 +- lang/lfortran/Makefile | 2 +- math/dihydrogen/Makefile | 2 +- math/heyoka/Makefile | 1 + math/libsemigroups/Makefile | 2 +- math/obake/Makefile | 1 + math/py-heyoka/Makefile | 2 +- misc/far2l/Makefile | 1 + multimedia/kodi/Makefile | 2 +- net-im/nheko/Makefile | 1 + net-p2p/litecoin-daemon/Makefile | 2 +- net-p2p/litecoin-utils/Makefile | 2 +- net-p2p/litecoin/Makefile | 2 +- net/arataga/Makefile | 2 +- net/ceph14/Makefile | 2 +- net/fb303/Makefile | 1 + net/fbzmq/Makefile | 2 +- net/gerbera/Makefile | 1 + net/knxd/Makefile | 2 +- net/mvfst/Makefile | 2 +- net/wangle/Makefile | 1 + science/cantera/Makefile | 2 +- science/chemicalfun/Makefile | 1 + science/openmc/Makefile | 1 + science/qiskit-aer/Makefile | 1 + security/fizz/Makefile | 1 + security/openconnect-gui/Makefile | 2 +- sysutils/lizardfs/Makefile | 2 +- textproc/fcitx5/Makefile | 2 +- www/proxygen/Makefile | 1 + www/restinio/Makefile | 2 +- x11/waybar/Makefile | 1 + 54 files changed, 54 insertions(+), 30 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5069df47ef8d799702b32b12ca081e90e662e332 commit 5069df47ef8d799702b32b12ca081e90e662e332 Author: Thierry Thomas <thierry@FreeBSD.org> AuthorDate: 2022-11-30 12:39:00 +0000 Commit: Thierry Thomas <thierry@FreeBSD.org> CommitDate: 2022-12-19 09:31:33 +0000 devel/libfmt: upgrade to 9.1.0 Releases notes at <https://github.com/fmtlib/fmt/releases>. PR: 268081 Approved by: maintainer’s time-out devel/libfmt/Makefile | 10 ++++++---- devel/libfmt/distinfo | 6 +++--- devel/libfmt/pkg-plist | 4 ++-- 3 files changed, 11 insertions(+), 9 deletions(-)
pkg-fallout@ have found at least 3 regressions, see https://pkg-status.freebsd.org/builds/default:default:131amd64:7dda4a77b8bb:beefy16#new_failed
science/chemicalfun will be fixed by PR 268509, and cad/openroad by PR 268513.