Bug 268143 - x11-clocks/wmclockmon: status change to remove BROKEN, port is functional, shar submission
Summary: x11-clocks/wmclockmon: status change to remove BROKEN, port is functional, sh...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jesper Schmitz Mouridsen
URL:
Keywords:
: 268000 268006 268133 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-12-03 23:41 UTC by Brendhan Horne
Modified: 2022-12-05 15:33 UTC (History)
2 users (show)

See Also:


Attachments
shar file attached in tar.gz format , contains working version of wmclockmon (392.22 KB, application/gzip)
2022-12-03 23:59 UTC, Brendhan Horne
no flags Details
shar version of working wmclockmon port (22.47 KB, application/x-shellscript)
2022-12-04 00:07 UTC, Brendhan Horne
no flags Details
minor changes to latest shar (25.57 KB, patch)
2022-12-04 01:05 UTC, Jesper Schmitz Mouridsen
no flags Details | Diff
removed two uneeded patches (24.39 KB, patch)
2022-12-04 10:59 UTC, Jesper Schmitz Mouridsen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brendhan Horne 2022-12-03 23:41:06 UTC
Short Notes:
OpenBSD has many patches for this port. Copy patches apply as needed. 
Upon completion run make stage-qa
Then run make check-plist
Make a shar file to attach with this report. 
Makefile now removes line that listed port as BROKEN, port is now considered functional. 




Long Notes
Received information from Thomas (Program Creator) that OpenBSD has a patched version of port. Get with JSM (FreeBSD Discord) and go over the patches. Make changes from work preformed previously Bug Report # 268133
Upon making edits and applying patches we were able to get a workable version without too many bandages and duct tape. JSM recommended to check with stage-qa and we made corrections to the Makefile based on the output until the results showed no issues. We then did make check-plist. Results are shown below. A shar was then created and is attached with this bug report. Program creator Thomas Nemeth will also be informed of this report. 

root@Necronomicon:/usr/ports/x11-clocks/wmclockmon # make stage-qa
====> Running Q/A tests (stage-qa)
/!\ To run stage-qa automatically add DEVELOPER=yes to your environment /!\
root@Necronomicon:/usr/ports/x11-clocks/wmclockmon #

root@Necronomicon:/usr/ports/x11-clocks/wmclockmon # make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
root@Necronomicon:/usr/ports/x11-clocks/wmclockmon #
Comment 1 Brendhan Horne 2022-12-03 23:59:47 UTC
Created attachment 238505 [details]
shar file attached in tar.gz format , contains working version of wmclockmon

shar file was considered too large 
shar filed was tarballed to tar.gz and attached here.
Comment 2 Brendhan Horne 2022-12-04 00:07:40 UTC
Created attachment 238506 [details]
shar version of working wmclockmon port

proper shar attachment
Comment 3 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2022-12-04 01:05:57 UTC
Created attachment 238507 [details]
minor changes to latest shar

Make portlint happier.
Remove from MOVED.
Added pkgconfig to USES.
Tested in poudriere.
Comment 4 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2022-12-04 01:20:29 UTC
*** Bug 268006 has been marked as a duplicate of this bug. ***
Comment 5 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2022-12-04 01:21:34 UTC
*** Bug 268000 has been marked as a duplicate of this bug. ***
Comment 6 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2022-12-04 01:22:00 UTC
*** Bug 268133 has been marked as a duplicate of this bug. ***
Comment 7 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2022-12-04 10:59:21 UTC
Created attachment 238508 [details]
removed two uneeded patches

The Makefile.am file patches are not needed.
Comment 8 Brendhan Horne 2022-12-05 01:01:32 UTC
JSM, thank you for that.
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-12-05 15:13:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9d74a305e773815efa751ef3e4182bb660450ad2

commit 9d74a305e773815efa751ef3e4182bb660450ad2
Author:     Jesper Schmitz Mouridsen <jsm@FreeBSD.org>
AuthorDate: 2022-12-05 15:09:04 +0000
Commit:     Jesper Schmitz Mouridsen <jsm@FreeBSD.org>
CommitDate: 2022-12-05 15:12:42 +0000

    x11-clocks/wmclockmon: resurrect

     Update to gtk20 with patch from debian.
     Fix build with -fno-common from openbsd patches.

    PR:             268143

 MOVED                                              |   1 -
 x11-clocks/Makefile                                |   1 +
 x11-clocks/wmclockmon/Makefile (new)               |  34 +++++
 x11-clocks/wmclockmon/distinfo (new)               |   3 +
 x11-clocks/wmclockmon/files/patch-src_main.c (new) |  33 +++++
 .../files/patch-wmclockmon-cal_main.c (new)        |  25 ++++
 .../files/patch-wmclockmon-cal_main.h (new)        |  11 ++
 .../files/patch-wmclockmon-cal_mainwindow.c (new)  | 147 +++++++++++++++++++++
 .../files/patch-wmclockmon-cal_mainwindow.h (new)  |  36 +++++
 .../files/patch-wmclockmon-config_actions.c (new)  |  27 ++++
 .../files/patch-wmclockmon-config_dialogs.c (new)  |  18 +++
 .../files/patch-wmclockmon-config_edit.c (new)     |  18 +++
 .../files/patch-wmclockmon-config_edit.h (new)     |  11 ++
 .../patch-wmclockmon-config_mainwindow.c (new)     |  76 +++++++++++
 .../patch-wmclockmon-config_mainwindow.h (new)     |  44 ++++++
 .../files/patch-wmclockmon-config_tools.c (new)    |  24 ++++
 .../patch-wmclockmon-config_variables.h (new)      |  41 ++++++
 x11-clocks/wmclockmon/pkg-descr (new)              |   2 +
 x11-clocks/wmclockmon/pkg-plist (new)              |  80 +++++++++++
 19 files changed, 631 insertions(+), 1 deletion(-)
Comment 10 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2022-12-05 15:33:10 UTC
Committed,thanks!