Bug 268336 - textproc/raptor2: fix build with clang 15
Summary: textproc/raptor2: fix build with clang 15
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks: 265425
  Show dependency tree / graph
 
Reported: 2022-12-12 16:15 UTC by Dimitry Andric
Modified: 2022-12-13 16:26 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+

Attachments
textproc/raptor2: fix build with clang 15 (2.71 KB, patch)
2022-12-12 16:16 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2022-12-12 16:15:59 UTC 
During an exp-run for llvm 15 (see bug 265425), it turned out that textproc/raptor2 failed to build with clang 15:

  raptor_parse.c:260:66: error: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' [-Wint-conversion]
    RAPTOR_ASSERT_OBJECT_POINTER_RETURN_VALUE(world, raptor_world, NULL);
                                                                   ^~~~
  /usr/include/sys/_null.h:34:14: note: expanded from macro 'NULL'
  #define NULL    ((void *)0)
                  ^~~~~~~~~~~
  ./raptor_internal.h:168:12: note: expanded from macro 'RAPTOR_ASSERT_OBJECT_POINTER_RETURN_VALUE'
      return ret; \
             ^~~

This was fixed in https://github.com/dajobe/raptor/commit/567d4d1a by upstream.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2022-12-12 16:16:24 UTC 
Created attachment 238732 [details]
textproc/raptor2: fix build with clang 15
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-13 04:41:25 UTC 
ship it
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-12-13 16:26:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2624cb3dcfc2581bf64eae4675e96940adfb64da

commit 2624cb3dcfc2581bf64eae4675e96940adfb64da
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-12-12 16:12:52 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-12-13 16:24:25 +0000

    textproc/raptor2: fix build with clang 15

    During an exp-run for llvm 15 (see bug 265425), it turned out that
    textproc/raptor2 failed to build with clang 15:

      raptor_parse.c:260:66: error: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' [-Wint-conversion]
        RAPTOR_ASSERT_OBJECT_POINTER_RETURN_VALUE(world, raptor_world, NULL);
                                                                       ^~~~
      /usr/include/sys/_null.h:34:14: note: expanded from macro 'NULL'
      #define NULL    ((void *)0)
                      ^~~~~~~~~~~
      ./raptor_internal.h:168:12: note: expanded from macro 'RAPTOR_ASSERT_OBJECT_POINTER_RETURN_VALUE'
          return ret; \
                 ^~~

    This was fixed in https://github.com/dajobe/raptor/commit/567d4d1a by
    upstream.

    PR:             268336
    Approved by:    tcberner (maintainer)
    MFH:            2022Q4

 textproc/raptor2/files/patch-commit-567d4d1a (new) | 47 ++++++++++++++++++++++
 1 file changed, 47 insertions(+)