Created attachment 239602 [details] poudriere build log I got a build failure in a poudriere when building mpv with Vulkan enabled. Disabling Vulkan fixes the build. $ freebsd-version 12.3-RELEASE-p10 The compile error message: In file included from ../video/out/vo_gpu_next.c:21: /usr/local/include/libplacebo/renderer.h:29:10: fatal error: 'libplacebo/shaders/icc.h' file not found #include <libplacebo/shaders/icc.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ninja: build stopped: subcommand failed. *** Error code 1
as you can see at https://cgit.freebsd.org/ports/tree/graphics/libplacebo/pkg-plist#n19 building graphics/libplacebo with LCMS2 should fix it too as that missing header is installed only then
If you disable LCMS2 option in graphics/libplacebo then also disable LCMS2 option in multimedia/mpv. The ports framework currently doesn't support requesting dependencies built with specific options enabled/disabled.
I can confirm that enabling LCMS2 in libplacebo fixes the build. Note that originally I had disabled LCMS2 in both mpv and libplacebo, and the build failed.
(In reply to serpent7776 from comment #3) The build failure with LCMS disabled in both libplacebo and mpv is reproducible. The issue seems to be with the headers installed by libplacebo. include/libplacebo/renderer.h unconditionally includes icc.h, regardless of whether the port is built with or without lcms2 support, but the icc.h file is only installed when it has lcms2 support.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3199ade18ee5f63a8714929e01e073492e395d1e commit 3199ade18ee5f63a8714929e01e073492e395d1e Author: Jan Beich <jbeich@FreeBSD.org> AuthorDate: 2023-02-13 16:12:54 +0000 Commit: Jan Beich <jbeich@FreeBSD.org> CommitDate: 2023-02-13 16:18:11 +0000 graphics/libplacebo: always install headers after f23f6a9c6a74 https://code.videolan.org/videolan/libplacebo/-/commit/1956dbb57354 https://code.videolan.org/videolan/libplacebo/-/commit/9894cdf2ee27 https://code.videolan.org/videolan/libplacebo/-/commit/46494038d21d PR: 269061 graphics/libplacebo/Makefile | 1 + graphics/libplacebo/pkg-plist | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-)
A commit in branch 2023Q1 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=92446ec67a9a14a703321709516fdd76f0610103 commit 92446ec67a9a14a703321709516fdd76f0610103 Author: Jan Beich <jbeich@FreeBSD.org> AuthorDate: 2023-02-13 16:12:54 +0000 Commit: Jan Beich <jbeich@FreeBSD.org> CommitDate: 2023-02-13 16:18:29 +0000 graphics/libplacebo: always install headers after f23f6a9c6a74 https://code.videolan.org/videolan/libplacebo/-/commit/1956dbb57354 https://code.videolan.org/videolan/libplacebo/-/commit/9894cdf2ee27 https://code.videolan.org/videolan/libplacebo/-/commit/46494038d21d PR: 269061 (cherry picked from commit 3199ade18ee5f63a8714929e01e073492e395d1e) graphics/libplacebo/Makefile | 1 + graphics/libplacebo/pkg-plist | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-)