Bug 269156 - databases/clickhouse: update to 22.12.3.5
Summary: databases/clickhouse: update to 22.12.3.5
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2023-01-25 20:03 UTC by Igor Valkov
Modified: 2023-03-08 08:12 UTC (History)
3 users (show)

See Also:


Attachments
databases/clickhouse: update to 22.12.3.5 (234.41 KB, patch)
2023-01-25 20:18 UTC, Igor Valkov
no flags Details | Diff
databases/clickhouse: update to 22.12.3.5 (652.73 KB, patch)
2023-01-30 20:26 UTC, Igor Valkov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Valkov 2023-01-25 20:03:31 UTC
Updated from 22.1.3.7 to 22.12.3.5

And also activated s3 storage, disabled in FreeBSD before.

Works fine in cluster mode in production 3 weeks.
Comment 1 Igor Valkov 2023-01-25 20:18:27 UTC
Created attachment 239707 [details]
databases/clickhouse: update to 22.12.3.5
Comment 2 Igor Valkov 2023-01-25 20:23:05 UTC
patch is gzipped
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-26 18:31:38 UTC
The patch seems wrong... it is a zipped file. Is this intended?
Comment 4 Igor Valkov 2023-01-26 18:57:44 UTC
(In reply to Fernando Apesteguía from comment #3)
yes. gzip. without gzip, size of file is over 1000kb and won't let me attach
Comment 5 Igor Valkov 2023-01-26 19:00:22 UTC
(In reply to Fernando Apesteguía from comment #3)

this is unzipped same file: http://public.fbsd.viaprog.eu/clickhouse-22.12.3.5.diff
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-27 22:15:27 UTC
Unfortunately I can't build this thing. It eats up all the available memory :S
Comment 7 Alexey Dokuchaev freebsd_committer freebsd_triage 2023-01-30 02:10:30 UTC
(In reply to Igor A. Valkov from comment #4)
> size of file is over 1000kb and won't let me attach
99% of the lines in the pkg-plist file are %%DATADIR%%-test/something (apparently, a test suite).  Why are they being installed, are they really needed on the end-user's system?
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-30 08:27:29 UTC
In addition, these scripts would need to replace the shebang line at the beginning of the files, probably with REINPLACE_CMD:

====> Running Q/A tests (stage-qa)
Error: '/usr/bin/expect' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/02160_client_autocomplete_parse_query.expect'
Error: '/usr/bin/expect' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/02310_clickhouse_local_INSERT_progress_profile_events.expect'
Error: '/usr/bin/expect' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/02310_clickhouse_client_INSERT_progress_profile_events.expect'
Error: '/usr/bin/clickhouse-local' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/02203_shebang'
Error: '/usr/bin/expect' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/02204_fractional_progress_bar_long.sh'
Error: '/usr/bin/expect' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/02417_repeat_input_commands.expect'
Error: '/bin/bash' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/add-test'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/01078_window_view_alter_query_watch.py'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/01082_window_view_watch_limit.py'
Error: '/usr/bin/expect' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/02352_interactive_queries_from_file.expect'
Error: '/usr/bin/expect' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/02456_progress_tty.expect'
Error: '/usr/bin/expect' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/02493_inconsistent_hex_and_binary_number.expect'
Error: '/usr/bin/expect' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/02480_client_option_print_num_processed_rows.expect'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'share/clickhouse-test/queries/0_stateless/02473_infile_progress.py'
*** Error code 1

Igor, would you be able to look at these and the thing Alexey pointed out? Maybe tests don't need to be installed, or they might be installed conditionally.
Comment 9 Igor Valkov 2023-01-30 20:26:25 UTC
Created attachment 239818 [details]
databases/clickhouse: update to 22.12.3.5

new version of patch
Comment 10 Igor Valkov 2023-01-30 20:27:50 UTC
(In reply to Fernando Apesteguía from comment #8)
I have uploaded the new version of the patch. Check, please.
Comment 11 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-31 22:35:13 UTC
(In reply to Igor A. Valkov from comment #10)
https://pdr.bofh.network/data/131-fernape/2023-01-31_10h39m00s/logs/errors/clickhouse-22.12.3.5.log

Please check the patches before submission. In particular, run poudriere with DEVELOPER=yes in make.conf

https://docs.freebsd.org/en/books/porters-handbook/book/#porting-testing
Comment 12 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-08 08:12:32 UTC
> 1 month.