Bug 269267 - security/gostsum: fix build on armv7
Summary: security/gostsum: fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-31 21:37 UTC by Robert Clausecker
Modified: 2023-02-05 14:54 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (rozhuk.im)
eduardo: merge-quarterly+


Attachments
security/gostsum: fix build on armv7 (3.09 KB, patch)
2023-01-31 21:37 UTC, Robert Clausecker
fuz: maintainer-approval? (rozhuk.im)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2023-01-31 21:37:36 UTC
Created attachment 239834 [details]
security/gostsum: fix build on armv7

The build is fixed by adding some missing bits of assembly code.
Add some more assembly code for arm64 for good measure.
While we are at it, fix a warning due to a missing include file.

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Please MFH if possible.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-02-05 14:51:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=154cb0fbb0b42ccbbf26a17dd9a2c43ed268cf06

commit 154cb0fbb0b42ccbbf26a17dd9a2c43ed268cf06
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2023-02-05 14:48:18 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-02-05 14:50:10 +0000

    security/gostsum: Fix build on armv7

     The build is fixed by adding some missing bits of assembly code.
     Add some more assembly code for arm64 for good measure.
     While we are at it, fix a warning due to a missing include file.

    PR:             269267
    Approved by:    portmgr blanket
    MFH:            2023Q1 (build fixes)

 security/gostsum/Makefile                     |  1 +
 security/gostsum/files/patch-gosthash.c (new) | 68 +++++++++++++++++++++++++++
 2 files changed, 69 insertions(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-02-05 14:53:33 UTC
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5d9b2ceee1615c045bf9ddf9a515d925b2206cd2

commit 5d9b2ceee1615c045bf9ddf9a515d925b2206cd2
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2023-02-05 14:48:18 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-02-05 14:51:57 +0000

    security/gostsum: Fix build on armv7

     The build is fixed by adding some missing bits of assembly code.
     Add some more assembly code for arm64 for good measure.
     While we are at it, fix a warning due to a missing include file.

    PR:             269267
    Approved by:    portmgr blanket
    MFH:            2023Q1 (build fixes)

    (cherry picked from commit 154cb0fbb0b42ccbbf26a17dd9a2c43ed268cf06)

 security/gostsum/Makefile                     |  1 +
 security/gostsum/files/patch-gosthash.c (new) | 68 +++++++++++++++++++++++++++
 2 files changed, 69 insertions(+)
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2023-02-05 14:54:44 UTC
Committed, thanks!