Bug 269288 - net/gmid: change Makefile due to SSL build conflicts in other ports
Summary: net/gmid: change Makefile due to SSL build conflicts in other ports
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-02 11:49 UTC by B.F.G. Stobiecki
Modified: 2023-02-04 18:54 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description B.F.G. Stobiecki 2023-02-02 11:49:56 UTC
There is a build dependency in gmid on libressl which provides libtls.so which is not available in both base and ports version of openssl. This however breaks ports which depend on openssl features that libressl does not provide (see zabbix for example). Playing with make.conf won't change much in this case as both SSL implementations are mutually exclusive.

This can be mitigated by using alternative dependency providing libtls.so, which is libretls. Consider this diff:

--- Makefile.orig       2023-02-02 12:17:19.373669000 +0100
+++ Makefile    2023-02-02 12:17:02.410470000 +0100
@@ -11,7 +11,7 @@
 LICENSE_FILE=  ${WRKSRC}/LICENSE

 LIB_DEPENDS=   libevent.so:devel/libevent \
-               libtls.so:security/libressl
+               libtls.so:security/libretls

 USES=          localbase pkgconfig ssl
 USE_RC_SUBR=   gmid
Comment 1 Omar Polo 2023-02-03 10:06:43 UTC
As discussed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257098 too, I'm not opposed to building net/gmid with libretls.

I'm not sure what's the preferred way to link to libtls on FreeBSD; fwiw gmid is developed on OpenBSD with libressl but comprehensive testing is done against libretls (on linux usually) too.  i'll defer the final decision to the porters :)

Thanks!
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-04 18:54:05 UTC
Committed,

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-02-04 18:54:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2e5b1d6f7c5ffa75a61f1fd0b57100e7c277f58a

commit 2e5b1d6f7c5ffa75a61f1fd0b57100e7c277f58a
Author:     B.F.G. Stobiecki <bjfs84@gmail.com>
AuthorDate: 2023-02-03 12:06:32 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-02-04 18:49:38 +0000

    net/gmid: change Makefile due to SSL build conflicts in other ports

    Use libretls instead of libressl. The port works fine with both but the latter
    has caused problems in the past.

    PR:             269288
    Reported by:    bjfs84@gmail.com
    Approved by:    freebsd@omarpolo.com (maintainer)

 net/gmid/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)