Bug 269314 - dns/libpsl: Revert commit 5592c5ea0729b53697958bd1f1cc7054123196f1
Summary: dns/libpsl: Revert commit 5592c5ea0729b53697958bd1f1cc7054123196f1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-03 22:13 UTC by Daniel Engberg
Modified: 2023-02-12 18:47 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-02-03 22:13:58 UTC 
This breaks "make test", it also adds back bogus NLS option

https://github.com/rockdaboot/libpsl/blob/master/po/POTFILES.in
https://github.com/rockdaboot/libpsl/commit/e87d463d04dbab922e6fe72f6df173bcebebe351

I can add back IDN support if that's of concern...
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-02-11 08:49:42 UTC 
Friendly ping
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-02-12 18:34:40 UTC 
The NLS option will be removed.

As I said in the reply of nghttp2, I'd like to follow official build process. Last time I checked it, there wasn't meson. Now I checked it again and meson is documented in the "Build from Git" part. I'm ready to convert it to meson.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-02-12 18:46:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bccc46e0b233d89c0db1e5efb50bacfd0da5296f

commit bccc46e0b233d89c0db1e5efb50bacfd0da5296f
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2023-02-12 18:36:39 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2023-02-12 18:36:39 +0000

    dns/libpsl: Convert to meson

    - Remove NLS option
    - Bump PORTREVISION for package change

    PR:             269314

 dns/libpsl/Makefile | 32 ++++++++++++--------------------
 1 file changed, 12 insertions(+), 20 deletions(-)