Bug 269597 - www/yt-dlp: Update to 2023.02.17
Summary: www/yt-dlp: Update to 2023.02.17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL: https://github.com/yt-dlp/yt-dlp/rele...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-16 21:06 UTC by Ivan Rozhuk
Modified: 2023-02-17 18:21 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
patch (1.38 KB, patch)
2023-02-16 21:06 UTC, Ivan Rozhuk 		no flags Details | Diff
Patch for yt-dlp (1.60 KB, patch)
2023-02-17 08:22 UTC, Daniel Engberg 		no flags Details | Diff
Patch for yt-dlp (1.19 KB, patch)
2023-02-17 16:32 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2023-02-16 21:06:32 UTC 
Created attachment 240190 [details]
patch

Non release, fix play issue.
Comment 1 Lorenzo Salvadore freebsd_committer freebsd_triage 2023-02-16 21:44:38 UTC 
I have tested the patch and it fixes the issue reported in https://github.com/yt-dlp/yt-dlp/issues/6247 on my machine.

Thanks Ivan.
Comment 2 Lorenzo Salvadore freebsd_committer freebsd_triage 2023-02-16 21:47:21 UTC 
Comment on attachment 240190 [details]
patch

^Triage: Ivan, please set the maintainer-approval attachment flag (to ?) and set the requestee field to the e-mail address of the maintainer to ask for maintainer approval

Attachment -> Details -> maintainer-approval [?]

I have done it for you this time.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-02-17 08:22:30 UTC 
Created attachment 240203 [details]
Patch for yt-dlp

Use upstream release archive and backport commit 149eb0bbf34fa8fdf8d1e2aa28e17479d099e26b to fix https://github.com/yt-dlp/yt-dlp/issues/6247
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-02-17 08:22:52 UTC 
Can you give this a spin?
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2023-02-17 09:10:05 UTC 
(In reply to Daniel Engberg from comment #4)

Hi Daniel,

Why is the PATCH needed? There should be a comment explaining why.

Yuri
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2023-02-17 09:23:57 UTC 
It's to resolve the reported issue in PR (also see issue link) while keeping release version intact. Preferably we should also use release archives as recommended by Porters Handbook and integrity since upstream releases checksums.
Comment 7 Lorenzo Salvadore freebsd_committer freebsd_triage 2023-02-17 09:28:51 UTC 
Daniel's patch also fixes the issue on my machine.

^Triage: And Daniel's patch also needs the maintainer-approval request. Not a big deal since Yuri has seen it anyway, but it helps keeping things cleaner and clearer.
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2023-02-17 16:32:04 UTC 
Created attachment 240217 [details]
Patch for yt-dlp

Compile and runtime tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist)
Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 13.1-RELEASE (i386)
Comment 9 Yuri Victorovich freebsd_committer freebsd_triage 2023-02-17 18:21:06 UTC 
Committed, thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-02-17 18:21:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=357f249d883e809a5c399a2322230b977c773db5

commit 357f249d883e809a5c399a2322230b977c773db5
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-02-17 16:33:51 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-02-17 18:21:10 +0000

    www/yt-dlp: Update 2023.01.06 → 2023.02.17

    PR:     269597

 www/yt-dlp/Makefile | 6 ++++--
 www/yt-dlp/distinfo | 6 +++---
 2 files changed, 7 insertions(+), 5 deletions(-)