Bug 269879 - games/lwjgl: Update to 3.3.4-snapshot+2(?)
Summary: games/lwjgl: Update to 3.3.4-snapshot+2(?)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://github.com/LWJGL/lwjgl3/relea...
Keywords:
Depends on:
Blocks: 269900
  Show dependency treegraph
 
Reported: 2023-02-28 17:15 UTC by Clockwork
Modified: 2024-03-14 17:30 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (freebsd)


Attachments
0001-games-lwjgl-Update-3.3.1.patch (1.49 KB, patch)
2023-02-28 17:15 UTC, Clockwork
Clockwork6400: maintainer-approval? (freebsd)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Clockwork 2023-02-28 17:15:26 UTC
Created attachment 240484 [details]
0001-games-lwjgl-Update-3.3.1.patch

Hello

I managed to build lwjgl version 3.3.1 When I see only version 2.9.4 in the ports https://www.freshports.org/games/lwjgl/.

Is there a reason lwjgl hasn't been updated on FreeBSD yet???
Comment 1 Lorenzo Salvadore freebsd_committer freebsd_triage 2023-02-28 17:24:39 UTC
On Phabricator we have a long time opened review for an update to 3.2.2: https://reviews.freebsd.org/D31119 .

The patch proposed here is an update to 3.3.1, then I think we should try to move forward this one.

Clockwork: you might want to read carefully the phabricator review and see if you can find something in there to improve your own patch. You might also want to join the conversation there, maybe join effort with the original submitter for the update to 3.2.2.

I am going to add a link to this bug report on the Phabricator review.
Comment 2 Lorenzo Salvadore freebsd_committer freebsd_triage 2023-02-28 17:26:49 UTC
Comment on attachment 240484 [details]
0001-games-lwjgl-Update-3.3.1.patch

^Triage: When you ask for maintainer-approval, please remember to also add the maintainer email address in the "Requestee:" field.
Comment 3 Clockwork 2023-03-01 16:02:00 UTC
I found the real reason

I have checked the ports that depend on this lib.

* games/sokobano depends on the java/jmf port, but I was unable to build it due to licensing restrictions;
* games/minecraft-client is also outdated, although it builds with both the old version of lwjgl and the new 3.3.1 without problems;
* games/multimc seems to be outdated a long time ago and there are versions 0.6.14 and 0.6.16. It seems that the maintainer has not raised the issue yet:
https://portscout.freebsd.org/me@tsundoku.ne.jp.html
However, I managed to build it using the found patch:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269897

This looks like a major dependency that caused it to not be updated. https://github.com/freebsd/freebsd-ports/blob/main/games/multimc/pkg-message
Comment 4 Lorenzo Salvadore freebsd_committer freebsd_triage 2023-03-11 12:56:52 UTC
Clockwork, thank you very much for your patch. Unfortunately, there is something wrong with it.

Look at distinfo: the old distribution file and new distribution file have exactly the same size and exactly the same SHA256. This is extremely unlikely.

Looking with more attention to your patch, I see that the port defines GH_TAGNAME and you did not change it: GH_TAGNAME is defined to a specific commit. So both the original port and your patched port download the distribution file corresponding to the same commit (ignoring the DISTVERSION value).

You are welcome to try again updating this port if you want. If you want to try, I suggest you look at https://github.com/LWJGL/lwjgl3 and maybe create a new port for it instead of updating this one. Indeed, according to https://github.com/LWJGL/lwjgl/blob/master/README.md , lwjgl is unmaintained upstream and has been replaced by lwjgl3. Maybe try to join the effort already started in https://reviews.freebsd.org/D31119 .
Comment 5 Clockwork 2023-03-11 16:26:56 UTC
(In reply to Lorenzo Salvadore from comment #4)

Thank you very much for noticing. I was not attentive. This explains why it came together so easily.
I'm currently trying to rebuild the port without GH_TAGNAME but I'm getting errors

```
Buildfile: /usr/ports/games/lwjgl3/work/lwjgl3-3.3.1/build.xml

BUILD FAILED
/usr/ports/games/lwjgl3/work/lwjgl3-3.3.1/build.xml:13: Cannot find /usr/ports/games/lwjgl3/work/lwjgl3-3.3.1/config/${platform}/build.xml imported from /usr/ports/games/lwjgl3/work/lwjgl3-3.3.1/build.xml

Total time: 0 seconds
```

It looks like there is no freebsd content in the ${config} directory and using a different ${platform} won't help. It will take much longer. I don't understand how to solve/work this.

Otherwise, can try to continue patch 3.2.2 from the revision, if it builds and works.
Comment 6 ykla 2023-09-19 14:03:56 UTC
Any update ?
Comment 7 Ivan 2023-11-22 19:01:20 UTC
Hi,

Good news, guys!

LWJGL now have FreeBSD support!

Please update the port to 3.3.4-snapshot+2

There is detailed information:
https://github.com/LWJGL/lwjgl3/issues/421
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2023-12-09 17:12:01 UTC
What target to build jar+native libraries?
Comment 9 Ivan 2023-12-10 13:43:47 UTC
Here is a similar port:

[NEW PORT] games/lwjgl3: Lightweight Java Game Library 3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275279
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2024-01-22 19:21:54 UTC
Check this please: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275279#c4
Comment 11 Clockwork 2024-01-23 17:47:26 UTC
Sorry, but I don't have time to participate in the project right now.

This information is outdated, so this port can't be snapshot+2. I see someone added a lwjgl3 port targeting the same source, you need an answer from the current maintainer - er2.
Comment 12 commit-hook freebsd_committer freebsd_triage 2024-02-27 21:26:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3a0031639dc5fe8d44b003fbf93512d8aacc4648

commit 3a0031639dc5fe8d44b003fbf93512d8aacc4648
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-02-27 21:09:51 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-02-27 21:25:47 +0000

    graphics/spirv-cross: new port - required for games/lwjgl3

    Tool for parsing and converting SPIR-V to other shader languages.

    This port required for build lwjgl 3, and lwjgl 3 required for Java
    Minecraft Client 1.20.x run on FreeBSD without linux compatibility layer.

    PR:                     275279 269879 269900
    Approved by:            arrowd (mentor)
    Differential Revision:  https://reviews.freebsd.org/D44118

 graphics/Makefile                    |  1 +
 graphics/spirv-cross/Makefile (new)  | 21 ++++++++++++++++
 graphics/spirv-cross/distinfo (new)  |  3 +++
 graphics/spirv-cross/pkg-descr (new) | 16 ++++++++++++
 graphics/spirv-cross/pkg-plist (new) | 49 ++++++++++++++++++++++++++++++++++++
 5 files changed, 90 insertions(+)
Comment 13 commit-hook freebsd_committer freebsd_triage 2024-02-27 21:26:40 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c3d51eebc94b491afe0e26b2bfbdd39b09c1090d

commit c3d51eebc94b491afe0e26b2bfbdd39b09c1090d
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-02-27 21:19:52 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-02-27 21:25:48 +0000

    graphics/openxr: new port - required for games/lwjgl3

    OpenXR provides access to Augmented and Virtual Reality (XR-platforms).

    This port required for build lwjgl 3, and lwjgl 3 required for Java
    Minecraft Client 1.20.x run on FreeBSD without linux compatibility layer.

    PR:                     275279 269879 269900
    Approved by:            arrowd (mentor)
    Differential Revision:  https://reviews.freebsd.org/D44119

 graphics/Makefile                                    |  1 +
 graphics/openxr/Makefile (new)                       | 20 ++++++++++++++++++++
 graphics/openxr/distinfo (new)                       |  3 +++
 graphics/openxr/files/patch-src_CMakeLists.txt (new) | 11 +++++++++++
 graphics/openxr/pkg-descr (new)                      |  3 +++
 graphics/openxr/pkg-plist (new)                      | 13 +++++++++++++
 6 files changed, 51 insertions(+)
Comment 14 commit-hook freebsd_committer freebsd_triage 2024-03-01 16:48:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f892ca876965b22946bfdae27ad875eecce9a3b8

commit f892ca876965b22946bfdae27ad875eecce9a3b8
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-03-01 16:45:23 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-03-01 16:48:00 +0000

    graphics/khronos-texture: new port - required for games/lwjgl3

    This port required for build lwjgl 3, and lwjgl 3 required for run Java
    Minecraft Client 1.20.x on FreeBSD without linux compatibility layer.

    PR:                     275279 269879 269900
    Approved by:            arrowd (mentor)
    Differential Revision:  https://reviews.freebsd.org/D44120

 graphics/khronos-texture/Makefile (new)  | 45 ++++++++++++++++++++++++++++++++
 graphics/khronos-texture/distinfo (new)  |  3 +++
 graphics/khronos-texture/pkg-descr (new) | 11 ++++++++
 graphics/khronos-texture/pkg-plist (new) | 16 ++++++++++++
 4 files changed, 75 insertions(+)
Comment 15 Vladimir Druzenko freebsd_committer freebsd_triage 2024-03-07 15:56:21 UTC
Review with port games/lwjgl3: https://reviews.freebsd.org/D44263
Comment 16 commit-hook freebsd_committer freebsd_triage 2024-03-14 17:22:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=680dc7bb031d0f708c2dd38f055ec8d63ee68b8a

commit 680dc7bb031d0f708c2dd38f055ec8d63ee68b8a
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-03-14 17:14:40 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-03-14 17:21:38 +0000

    games/lwjgl3: update to 3.3.4.20231218

    This port required for games/minecraft-client (Java Minecraft Client)
    1.20.x run on FreeBSD without linux compatibility layer.

    Upstream support FreeBSD on amd64 only, but on linux they support
    i386, arm* and ppc* too - if somebody can and want to add support
    for other arches - welcome.

    PR:                     275279 269879 269900
    Approved by:            arrowd (mentor)
    Differential Revision:  https://reviews.freebsd.org/D44263

 games/Makefile                                     |   1 +
 games/lwjgl3/Makefile                              | 154 ++++++++++++++-------
 games/lwjgl3/distinfo                              |  36 ++++-
 games/lwjgl3/files/patch-build.xml (gone)          |  10 --
 .../files/patch-config_build-definitions.xml (new) |  12 ++
 .../files/patch-config_freebsd_build.xml (new)     |  23 +++
 ...n_java_org_lwjgl_system_MemoryManage.java (new) |  12 ++
 ...a_org_lwjgl_system_jemalloc_JEmalloc.java (new) |  69 +++++++++
 ..._java_org_lwjgl_util_shaderc_Shaderc.java (new) |  11 ++
 ...erated_java_org_lwjgl_util_spvc_Spvc.java (new) |  11 ++
 ...patch-platform_build__bsd_ant__build.xml (gone) |  22 ---
 .../files/patch-update-dependencies.xml (new)      |  20 +++
 games/lwjgl3/pkg-descr                             |  13 +-
 games/lwjgl3/pkg-plist (new)                       | 140 +++++++++++++++++++
 14 files changed, 445 insertions(+), 89 deletions(-)
Comment 17 commit-hook freebsd_committer freebsd_triage 2024-03-14 17:23:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dae9e94dee9b0b5da30557653107b7419e260ca0

commit dae9e94dee9b0b5da30557653107b7419e260ca0
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-03-14 17:11:14 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-03-14 17:21:38 +0000

    games/lwjgl3: bootstrap from games/lwjgl

    Copy games/lwjgl unchanged

    PR:                     275279 269879 269900
    Approved by:            arrowd (mentor)

 games/lwjgl3/Makefile (new)                        | 79 ++++++++++++++++++++++
 games/lwjgl3/distinfo (new)                        |  3 +
 games/lwjgl3/files/patch-build.xml (new)           | 10 +++
 .../patch-platform_build__bsd_ant__build.xml (new) | 22 ++++++
 games/lwjgl3/pkg-descr (new)                       |  1 +
 5 files changed, 115 insertions(+)