Bug 270879 - x11-fm/krusader2: viewing archives does not work
Summary: x11-fm/krusader2: viewing archives does not work
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-kde (group)
URL: https://bugs.kde.org/show_bug.cgi?id=...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-16 14:07 UTC by Alexey Dokuchaev
Modified: 2023-05-05 05:52 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Dokuchaev freebsd_committer freebsd_triage 2023-04-16 14:07:50 UTC
Someone had reported that viewing archives as folders does not work in Krusader: *.zip archives appear empty, *.tar.* are opened with external program, and only *.7z are displayed correctly.  I've glanced at the sources, and see this:

    listCmd << fullPathName("unzip") << "-ZTs-z-t-h";

These options are not compatible with our native unzip(1), they are for Info-ZIP implementation.

This had been reported upstream (linked URL).
Comment 1 Vurefozu 2023-04-28 10:16:49 UTC
Installing the kio-extras package solves the problem.
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2023-04-28 12:46:12 UTC
(In reply to Vurefozu from comment #1)
> Installing the kio-extras package solves the problem.
Exactly which one?  There were two: 1) *.zip archives appeared empty, and 2) *.tar.* being opened with external program.

Also, it's still unclear why installing it fixes anything, we need in-depth analysis before we can commit a proper fix.
Comment 3 Vurefozu 2023-04-28 13:18:14 UTC
> 1) *.zip archives appeared empty
Solution to the problem:
/usr/bin/unzip
replaced by
/usr/local/bin/unzip

> 2) *.tar.* being opened with an external program.
Solution to the problem:
pkg install kio-extras


Also, kio-extras adds SFTP functionality to krusader.


The only thing that doesn't open as a directory is *.tar.lzma archives
Even after installing the "lzma" package and replacing
/usr/bin/lzma
on
/usr/local/bin/lzma
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2023-04-28 17:25:17 UTC
(In reply to Vurefozu from comment #3)
I looked into switching krusader to use the ${LOCALBASE} binary, e.g. here [1]


[1] https://invent.kde.org/utilities/krusader/-/blob/master/app/Archive/krarchandler.cpp
Comment 5 Alexey Dokuchaev freebsd_committer freebsd_triage 2023-04-30 02:36:48 UTC
(In reply to Vurefozu from comment #3)
> Solution to the [*.tar.*] problem:
> pkg install kio-extras
> Also, kio-extras adds SFTP functionality to krusader.
I'd still like to see in the code how exactly Krusader breaks without it, does it emit any warning?  Just to be sure that `devel/kio-extras' is indeed what's needed, not some dependency it pulls.
Comment 6 Vurefozu 2023-04-30 15:11:06 UTC
(In reply to Alexey Dokuchaev from comment #5)
> I'd still like to see in the code how exactly Krusader breaks without it, does it emit any warning?

I will not answer the question, it is necessary to ask the developers of krusader.
Comment 7 Alexey Dokuchaev freebsd_committer freebsd_triage 2023-05-05 05:52:50 UTC
(In reply to Vurefozu from comment #6)
> I will not answer the question, it is necessary to ask the developers of
> Krusader.
Right, what I meant is that whoever committing a fix should have sufficient domain knowledge and KDE/C++ experience to make proper judgement.