Bug 271057 - x11-toolkits/vte3: fix build with clang 16
Summary: x11-toolkits/vte3: fix build with clang 16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks: 271047
  Show dependency treegraph
 
Reported: 2023-04-24 22:05 UTC by Dimitry Andric
Modified: 2023-05-07 18:41 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
x11-toolkits/vte3: fix build with clang 16 (1.81 KB, patch)
2023-04-24 22:06 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2023-04-24 22:05:45 UTC
Clang 16 has a new error about integer values being outside the valid
range for enum types, which shows up when building x11-toolkits/vte3:

  ../src/vtepty.cc:577:16: error: integer value 234881535 is outside the valid range of values [0, 4095] for this enumeration type [-Wenum-constexpr-conversion]
          return GSpawnFlags(G_SPAWN_LEAVE_DESCRIPTORS_OPEN |
                 ^

Upstream already noticed this, and committed
https://gitlab.gnome.org/GNOME/vte/-/commit/9b41cd101429 as a fix, so
add this as an additional patch, until the next version is released.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2023-04-24 22:06:02 UTC
Created attachment 241718 [details]
x11-toolkits/vte3: fix build with clang 16
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-05-07 18:40:12 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2b2883921ec71c5b8521ddd450054c80d686ef55

commit 2b2883921ec71c5b8521ddd450054c80d686ef55
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-04-24 22:02:10 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-05-07 18:38:48 +0000

    x11-toolkits/vte3: fix build with clang 16

    Clang 16 has a new error about integer values being outside the valid
    range for enum types, which shows up when building x11-toolkits/vte3:

      ../src/vtepty.cc:577:16: error: integer value 234881535 is outside the valid range of values [0, 4095] for this enumeration type [-Wenum-constexpr-conversion]
              return GSpawnFlags(G_SPAWN_LEAVE_DESCRIPTORS_OPEN |
                     ^

    Upstream already noticed this, and committed
    https://gitlab.gnome.org/GNOME/vte/-/commit/9b41cd101429 as a fix, so
    add this as an additional patch, until the next version is released.

    PR:             271057
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2023Q2

 x11-toolkits/vte3/Makefile | 5 ++++-
 x11-toolkits/vte3/distinfo | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)