Bug 271524 - net/dpdk: Fix build with -Wstrict-prototypes
Summary: net/dpdk: Fix build with -Wstrict-prototypes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Baldwin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-20 00:56 UTC by John Baldwin
Modified: 2023-05-23 21:34 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (bruce.richardson)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Baldwin freebsd_committer freebsd_triage 2023-05-20 00:56:54 UTC 
Patch available at https://reviews.freebsd.org/D40170
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-05-20 20:45:51 UTC 
Build fixes like these are subject to portmgr's build fix blanket approval and do not require specific maintainer approval.
Comment 3 Bruce Richardson 2023-05-22 07:54:51 UTC 
LGTM.

I will submit patch for upstream to match.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-05-22 08:03:03 UTC 
^Triage: reporter is committer, assign accordingly.
Comment 5 John Baldwin freebsd_committer freebsd_triage 2023-05-23 21:34:47 UTC 
Forgot to tag the commit, but this was merged:

commit 74c810e22221e95130124559aaeb5e7a384360dc
Author: John Baldwin <jhb@FreeBSD.org>
Date:   Tue May 23 14:27:26 2023 -0700

    net/dpdk*: Use valid prototypes for function declarations with no arguments.
    
    Reviewed by:    fuz, Bruce Richardson (maintainer)
    Differential Revision:  https://reviews.freebsd.org/D40170