<https://github.com/HamedMasafi/GitKlient#readme>: > The project was transferred to KDE. Visit the following address to view > the source. > > https://invent.kde.org/sdk/gitklient https://invent.kde.org/sdk/kommit > Project 'sdk/gitklient' was moved to 'sdk/kommit'. Please update any > links and bookmarks that may still have the old path. In the description: uppercase G for Git. Thanks
Created attachment 243850 [details] devel/kommit: update WWW and description
Created attachment 243851 [details] devel/kommit: update WWW and description (fixed)
Created attachment 243857 [details] [PATCH] devel/kommit: Update pkg-descr and WWW
Comment on attachment 243857 [details] [PATCH] devel/kommit: Update pkg-descr and WWW Thanks for the patch. A few notes: * I don't think you need to bump PORTREVISION since you're basically only editing some metadata. * Doesn't it make more sense to point WWW to https://apps.kde.org/kommit/ (the app page) instead of the git repository?
(In reply to Raphael Kubo da Costa from comment #4) > … https://apps.kde.org/kommit/ … That's better, I wasn't aware of this page. Thanks.
Created attachment 243887 [details] [PATCH] devel/kommit: Update pkg-descr and WWW
Created attachment 245649 [details] [PATCH] devel/kommit: Update pkg-descr and WWW
lgtm
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=fb5043d6ed2cdbfe4fa8555178aca9184cc6a9a0 commit fb5043d6ed2cdbfe4fa8555178aca9184cc6a9a0 Author: Graham Perrin <grahamperrin@gmail.com> AuthorDate: 2023-10-16 16:17:01 +0000 Commit: Joel Bodenmann <jbo@FreeBSD.org> CommitDate: 2023-10-16 16:19:09 +0000 devel/kommit: Update WWW and description PR: 271682 Approved by: tcberner (mentor) devel/kommit/Makefile | 6 +++--- devel/kommit/pkg-descr | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
Committed - Thanks!
Thanks for reviewing and committing my patch. It may look somewhat childish from me, as I like my authorship to be stated in commit log :) Actually I'm not a bit jealous to respective Graham Perrin, I just like to have more my patches being accepted :) Could you, please, fix it?
(In reply to Andrey Korobkov from comment #11) Moin moin Oh, this was an unfortunate misunderstanding. There is no repo-surgery however, so we cannot amend it. Thanks a lot for your contribution, and we'll make sure to do the proper attribution next time. (Btw, if you upload a git-format patch (e.g. running 'git format-patch -1'), then author information is automatically correct :) ) mfg Tobias
Hi (In reply to Tobias C. Berner from comment #12) Was attachment 245649 [details] not correct? Here, with an outdated copy of the tree: % git -C /usr/ports am /tmp/0001-devel-kommit-Update-pkg-descr-and-WWW.patch Applying: devel/kommit: Update pkg-descr and WWW % git -C /usr/ports log -n 1 commit 4e223bdb1015ba22daecfdba609c0371bdc5bdd6 (HEAD -> main) Author: Andrey Korobkov <alster@vinterdalen.se> Date: Sat Aug 5 04:23:17 2023 +0400 devel/kommit: Update pkg-descr and WWW PR: 271682 % git-am(1) <https://git-scm.com/docs/git-am> <https://man.freebsd.org/cgi/man.cgi?query=git-am&sektion=1&manpath=freebsd-ports>
> Hi … I forgot to say, thanks!
Hi and thanks for peacefully resolving the issue in kind and polite way! :) Let's have it closed. I like to work alongside with all of you on such an interesting project as FreeBSD and already work on future patches. Best regards, Andrey
Andrey, apologies for the mistake - entirely my fault. This was not intentional at all.
No problem at all, Joel, don't worry! I'm even glad this small mistake happened as it showed me how friendly and polite people are in this community. :) I also would like to became a committer one day. And now I'm sure you all will also be kind and supportive, would I make any mistake. Thank you!
(In reply to Tobias C. Berner from comment #12) tcberner@ My apologies: when I posted <https://lists.freebsd.org/archives/dev-commits-ports-all/2023-October/084667.html>, in the list of three CC recipients I misspelt the domain alongside your user ID, so you probably did not notice the post. (I had terrible trouble, at the time, with the port of Thunderbird, problems far broader than the description at <https://bugzilla.mozilla.org/show_bug.cgi?id=1856513>. It wasn't responding properly to keystrokes, I should have paid closer attention before sending the email. Sorry for the carelessness.)