Bug 271775 - multimedia/shotcut: update to 24.10.29
Summary: multimedia/shotcut: update to 24.10.29
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Charlie Li
URL: https://www.shotcut.org/blog/new-rele...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-02 00:46 UTC by Jason E. Hale
Modified: 2024-11-16 16:49 UTC (History)
7 users (show)

See Also:
vishwin: maintainer-feedback+


Attachments
shotcut-23.06.23 (apply with git am) (23.74 KB, patch)
2023-06-02 00:46 UTC, Jason E. Hale
no flags Details | Diff
shotcut-23.06.23 - fix typo in commit msg (apply with git am) (23.74 KB, patch)
2023-06-02 02:01 UTC, Jason E. Hale
no flags Details | Diff
shotcut-23.06.14 (apply with git am) (24.33 KB, patch)
2023-06-16 17:41 UTC, Jason E. Hale
no flags Details | Diff
multimedia/shotcut: Update to 23.07.29 (apply with git am) (24.82 KB, patch)
2023-07-30 17:01 UTC, Jason E. Hale
no flags Details | Diff
with more popular audio and video formats (25.78 KB, patch)
2023-09-15 01:31 UTC, Tomoyuki Sakurai
no flags Details | Diff
tweaked port to build and run shotcut 241029 (31.00 KB, application/x-tar)
2024-11-15 16:31 UTC, Frank Reisert
vishwin: maintainer-approval-
Details
Update 22.06.23 → 24.10.29 (24.27 KB, patch)
2024-11-16 16:49 UTC, Vladimir Druzenko
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason E. Hale freebsd_committer freebsd_triage 2023-06-02 00:46:59 UTC
Created attachment 242545 [details]
shotcut-23.06.23 (apply with git am)

Build 12.4 amd64: OK
Build -CURRENT amd64: OK
Run test on -CURRENT amd64: OK

Development has moved to Qt6 and a wrapper script is needed to suppress the Qt5 mlt7 plugins from loading to prevent crashes (included).
Comment 1 Charlie Li freebsd_committer freebsd_triage 2023-06-02 00:59:01 UTC
(setting maintainer-feedback to avoid timeout only, do not construe as approved)

What does run test mean here? All controls render properly and usable? Timeline functional? Video exports/renders as expected?
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2023-06-02 01:07:17 UTC
(In reply to Charlie Li from comment #1)
All controls and the timeline function properly as far as I can tell. Video export works. My main motivation for working on this was the broken Rich Text filter in the previous version. This is confirmed working now with the edit box appearing properly in the preview window.
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2023-06-02 02:01:07 UTC
Created attachment 242547 [details]
shotcut-23.06.23 - fix typo in commit msg (apply with git am)
Comment 4 mmatalka 2023-06-09 13:40:27 UTC
I've done a test render with this patch and it seems to be working.  I'll do a more complicated project this weekend.

Thank you.
Comment 5 Jason E. Hale freebsd_committer freebsd_triage 2023-06-16 17:41:44 UTC
Created attachment 242813 [details]
shotcut-23.06.14 (apply with git am)

Update to 23.06.14 released a couple days ago.
Comment 6 mmatalka 2023-06-16 20:59:43 UTC
I'm going to test this this weekend.


Related but different package: there is a bug in MLT which causes issues if you have a video without audio transition into another video.  The solution is in the commit marked in the link below.  I have tested and works for me.

https://github.com/mltframework/shotcut/issues/1442
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-06-16 21:25:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e936f94e5a1deb25d1ffc411e7d979df6eaff0df

commit e936f94e5a1deb25d1ffc411e7d979df6eaff0df
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2023-06-16 21:20:44 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2023-06-16 21:24:42 +0000

    multimedia/mlt7: Add patch to fix shotcut export

    https://github.com/mltframework/shotcut/issues/1442
    PR:             271775
    Reported by:    <mmatalka@gmail.com>

 multimedia/mlt7/Makefile | 5 ++++-
 multimedia/mlt7/distinfo | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)
Comment 8 Jason E. Hale freebsd_committer freebsd_triage 2023-06-16 21:27:24 UTC
(In reply to mmatalka from comment #6)
Should be fixed now with e936f94e5a1deb25d1ffc411e7d979df6eaff0df.
Comment 9 mmatalka 2023-06-19 12:51:08 UTC
I did a big edit and render this weekend and it was successful.
Comment 10 Jason E. Hale freebsd_committer freebsd_triage 2023-07-30 17:01:44 UTC
Created attachment 243708 [details]
multimedia/shotcut: Update to 23.07.29 (apply with git am)

Update to latest version.
Comment 11 mmatalka 2023-08-06 12:43:15 UTC
(In reply to Jason E. Hale from comment #10)

This one freezes my screen every now and then.  I'm not quite sure on a pattern, though.  Last time it was when I was making proxy files and tried to save my project.  The screen freezes, mouse doesn't move, I can't switch into a terminal window either.  I had to hard reboot.
Comment 12 mmatalka 2023-08-12 19:06:55 UTC
I think the freezes were related to the DRM version I was running.
Comment 13 Tomoyuki Sakurai 2023-09-15 01:31:41 UTC
Created attachment 244863 [details]
with more popular audio and video formats

added more audio and video format support. they are needed to edit video taken by my android phone.
Comment 14 Tomoyuki Sakurai 2023-09-15 01:34:08 UTC
forgot to mention: poudriere did not complain. "Text: Rich" filter is working.
Comment 15 Vladimir Druzenko freebsd_committer freebsd_triage 2023-10-06 19:43:15 UTC
New Version 23.09
https://shotcut.org/blog/new-release-230929/
Comment 16 Vladimir Druzenko freebsd_committer freebsd_triage 2023-12-09 15:29:56 UTC
23.11.29:
https://shotcut.org/blog/new-release-231129/
Comment 17 mmatalka 2023-12-12 16:37:26 UTC
I'm on FreeBSD-CURRENT and the latest patches work except the Timeline shows up as just white and is unusable it.  It's just a white box.  I cannot drag and drop anything into the area.  Keyframes screen shows normal, it's just the Timeline.
Comment 18 Jason E. Hale freebsd_committer freebsd_triage 2023-12-12 18:00:07 UTC
(In reply to mmatalka from comment #17)
> Timeline shows up as just white and is unusable

I already upstreamed a patch [1] to fix that issue [2] before Qt 6.6.0 even hit the ports tree.

[1] https://github.com/mltframework/shotcut/commit/4f92e2c3f4dc562fd92d631239a3203555c8ae52
[2] https://github.com/mltframework/shotcut/issues/1479
Comment 19 mmatalka 2023-12-13 15:36:10 UTC
(In reply to Jason E. Hale from comment #18)
Great!  I took the current existing patch and modified it to be the release that incorporates this and compiled and installed and now I got timeline back!
Comment 20 Vladimir Druzenko freebsd_committer freebsd_triage 2024-01-07 04:42:32 UTC
23.12.15:
https://shotcut.org/blog/new-release-231215/
Comment 21 Vladimir Druzenko freebsd_committer freebsd_triage 2024-01-30 19:48:50 UTC
New Version 24.01: Round and Round
Jan 28, 2024.
Version 24.01.28 is now available

https://www.shotcut.org/blog/new-release-240128/
Comment 22 seb 2024-03-11 15:53:41 UTC
I managed to upgrade the port locally to 24.02.29 but for some weird reason i had to remove all ".debug()" calls from 

work/src/shotcut/src/commands/filtercommands.cpp in ChangeParameterCommand::undo()

otherwise i got this error:

ld: error: undefined symbol: Mlt::Properties::debug(char const*, __sFILE*)
>>> referenced by filtercommands.cpp
>>>               src/CMakeFiles/shotcut.dir/commands/filtercommands.cpp.o:(Filter::ChangeParameterCommand::undo())
>>> referenced by filtercommands.cpp
>>>               src/CMakeFiles/shotcut.dir/commands/filtercommands.cpp.o:(Filter::ChangeParameterCommand::undo())
>>> referenced by filtercommands.cpp
>>>               src/CMakeFiles/shotcut.dir/commands/filtercommands.cpp.o:(Filter::ChangeParameterCommand::undo())


If someone could help me to understand the actual root cause i could try providing a patch to upgrade this port
Comment 23 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-06 10:04:44 UTC
New Version 24.04: Time After Time
Apr 28, 2024
Version 24.04.28 is now available

https://www.shotcut.org/blog/new-release-240428/
Comment 24 Jason E. Hale freebsd_committer freebsd_triage 2024-05-06 11:25:12 UTC
I don’t think the current maintainer really cares about this port anymore. It’s been almost a year since I submitted this update. Beyond immediate blocking and implying that I didn’t do enough testing, even though the current port is ancient and broken at runtime, there has been no further interaction.

My plate is pretty full right now, but I’ll try to update the port within a week or so and hand over maintainership to kde@ who maintains the mlt framework.
Comment 25 Charlie Li freebsd_committer freebsd_triage 2024-05-06 14:14:24 UTC
(In reply to Jason E. Hale from comment #24)
This is categorically false, my time has simply been limited lately. The immediate next version changed the build process significantly so that plus other deltas need worked on.
Comment 26 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-28 10:45:08 UTC
New Version 24.06
Jun 26, 2024.
https://github.com/mltframework/shotcut/releases/tag/v24.06.26
Comment 27 kaltheat 2024-10-10 14:46:26 UTC
Hi, this issue is over a year old!
Could you please upgrade the port?!


Meanwhile there is

New Version 24.09
Sep 13, 2024.
https://github.com/mltframework/shotcut/releases/tag/v24.09.13
Comment 28 Frank Reisert 2024-11-15 16:31:47 UTC
Created attachment 255201 [details]
tweaked port to build and run shotcut 241029
Comment 29 Frank Reisert 2024-11-15 16:36:24 UTC
New Version: 24.10

I'm on 14.1-RELEASE-p6 with llvm18-18.1.8_2 installed.  Shotcut 24.10.29 builds, 
runs, and works -- at least for my humble requirements -- without any ado.  Just 
tweaked the port a little bit.  Please see attachment in Comment 28.

regards
Frank
Comment 30 Vladimir Druzenko freebsd_committer freebsd_triage 2024-11-16 14:15:13 UTC
(In reply to Frank Reisert from comment #29)
Testing build your port in poudriere.
1. Better attach git diff (patch) too (I'll attach after testing).
2. Remove PORTREVISION (DISTVERSION changed) from Makefile.

Did you tested runtime?
Comment 31 Charlie Li freebsd_committer freebsd_triage 2024-11-16 14:18:03 UTC
Comment on attachment 255201 [details]
tweaked port to build and run shotcut 241029

Why is this a tarball? Please submit an actual diff so it can be more easily scrutinised.
Comment 32 Frank Reisert 2024-11-16 15:31:43 UTC
(In reply to Vladimir Druzenko from comment #30)
Sorry for the inconvenience I've caused.  I'm not familiar with the procedure.  
Just wanted to share a fix which worked for me.

> Did you tested runtime?
Sorry again, but I don't really get you here.  I'll try to answer anyway:  the thing 
compiled, installed and ran, so I did a bit of editing.  Which means that opening a 
source, timeline, a couple of editing tools and export to a specific encoding works.  
As I've already said: humble requirements.  What I did do cannot be called thorough 
testing.  

regards
Frank
Comment 33 Vladimir Druzenko freebsd_committer freebsd_triage 2024-11-16 16:49:58 UTC
Created attachment 255221 [details]
Update 22.06.23 → 24.10.29

(In reply to Frank Reisert from comment #32)
Runtime test (I mean) is exact what you did.